ci: Add Windows coverage for setup integration tests

Run the integration test workflow on windows-latest
  using cargo test while keeping the existing Nix path for Unix runners.

Update setup integration harness environment variables
  and expected local DB path to use Windows app-data locations consistently.

Author: davidabram

.github/workflows/cli-integration-tests.yml

@@ -12,14 +12,25 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
     timeout-minutes: 25
     steps:
       - name: Check out repository
         uses: actions/checkout@v6
 
       - name: Install Nix
+        if: matrix.os != 'windows-latest'
         uses: cachix/install-nix-action@v31
 
       - name: Run CLI integration test app
+        if: matrix.os != 'windows-latest'
         run: nix run .#cli-integration-tests
+
+      - name: Install Rust toolchain
+        if: matrix.os == 'windows-latest'
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Run setup integration tests on Windows
+        if: matrix.os == 'windows-latest'
+        working-directory: cli
+        run: cargo test --test setup_integration

cli/src/services/local_db.rs

@@ -206,6 +206,8 @@ pub(crate) fn resolve_state_data_root() -> Result<PathBuf> {
         if let Some(app_data) = std::env::var_os("APPDATA") {
             return Ok(PathBuf::from(app_data));
         }
+
+        return Ok(resolve_home_dir()?.join("AppData").join("Local"));
     }
 
     #[cfg(target_os = "macos")]

cli/src/services/observability.rs

@@ -2,7 +2,9 @@ use std::fs::{File, OpenOptions};
 use std::io::Write;
 #[cfg(unix)]
 use std::os::unix::fs::{MetadataExt, OpenOptionsExt, PermissionsExt};
-use std::path::{Path, PathBuf};
+#[cfg(unix)]
+use std::path::Path;
+use std::path::PathBuf;
 use std::sync::{Arc, Mutex};
 
 use anyhow::{anyhow, bail, Result};

cli/tests/setup_integration.rs

@@ -130,6 +130,8 @@ impl SetupIntegrationHarness {
             .current_dir(&self.repo_root)
             .env("XDG_STATE_HOME", &self.state_home)
             .env("HOME", &self.home_dir)
+            .env("LOCALAPPDATA", &self.state_home)
+            .env("APPDATA", &self.state_home)
             .env("GIT_CONFIG_GLOBAL", null_device_path())
             .env("GIT_CONFIG_NOSYSTEM", "1");
         command
@@ -289,10 +291,11 @@ fn setup_backup_suffix_collision() -> TestResult<()> {
 
     let expected_backup = canonical_repo_root.join(".opencode.backup.2");
     assert!(
-        second.stdout.contains(&format!(
-            "backup: existing target moved to '{}'",
-            expected_backup.display()
-        )),
+        candidate_path_strings(&expected_backup)
+            .iter()
+            .any(|candidate| second
+                .stdout
+                .contains(&format!("backup: existing target moved to '{candidate}'"))),
         "output should report backup to .backup.2 due to collision\nstdout:\n{}",
         second.stdout
     );
@@ -361,20 +364,14 @@ fn setup_hooks_repo_relative_path() -> TestResult<()> {
     );
 
     assert!(
-        result.stdout.contains(&format!(
-            "Repository root: '{}'",
-            canonical_repo_root.display()
-        )),
+        stdout_contains_path_line(&result.stdout, "Repository root", &canonical_repo_root),
         "output should contain canonical repository root '{}'\nstdout:\n{}",
         canonical_repo_root.display(),
         result.stdout
     );
 
     assert!(
-        result.stdout.contains(&format!(
-            "Hooks directory: '{}'",
-            expected_hooks_dir.display()
-        )),
+        stdout_contains_path_line(&result.stdout, "Hooks directory", &expected_hooks_dir),
         "output should contain hooks directory '{}'\nstdout:\n{}",
         expected_hooks_dir.display(),
         result.stdout
@@ -413,20 +410,14 @@ fn setup_hooks_repo_absolute_path() -> TestResult<()> {
     );
 
     assert!(
-        result.stdout.contains(&format!(
-            "Repository root: '{}'",
-            canonical_repo_root.display()
-        )),
+        stdout_contains_path_line(&result.stdout, "Repository root", &canonical_repo_root),
         "output should contain canonical repository root '{}'\nstdout:\n{}",
         canonical_repo_root.display(),
         result.stdout
     );
 
     assert!(
-        result.stdout.contains(&format!(
-            "Hooks directory: '{}'",
-            expected_hooks_dir.display()
-        )),
+        stdout_contains_path_line(&result.stdout, "Hooks directory", &expected_hooks_dir),
         "output should contain hooks directory '{}'\nstdout:\n{}",
         expected_hooks_dir.display(),
         result.stdout
@@ -920,6 +911,7 @@ mod pty_interactive {
         Ok(())
     }
 
+    #[cfg(not(target_os = "windows"))]
     #[test]
     fn setup_interactive_nontty_fail() -> TestResult<()> {
         let harness = SetupIntegrationHarness::new("sce-setup-nontty")?;
@@ -1292,10 +1284,12 @@ fn assert_setup_hooks_install_and_rerun(
         first.stderr
     );
     assert!(first.stdout.contains("Hook setup completed successfully."));
-    assert!(first.stdout.contains(&format!(
-        "Hooks directory: '{}'",
-        expected_hooks_directory.display()
-    )));
+    assert!(
+        stdout_contains_path_line(&first.stdout, "Hooks directory", expected_hooks_directory),
+        "first setup run should include hooks directory '{}':\n{}",
+        expected_hooks_directory.display(),
+        first.stdout
+    );
 
     for hook in REQUIRED_HOOK_NAMES {
         let expected_hook_path = expected_hooks_directory.join(hook);
@@ -1326,10 +1320,12 @@ fn assert_setup_hooks_install_and_rerun(
         second.stderr
     );
     assert!(second.stdout.contains("Hook setup completed successfully."));
-    assert!(second.stdout.contains(&format!(
-        "Hooks directory: '{}'",
-        expected_hooks_directory.display()
-    )));
+    assert!(
+        stdout_contains_path_line(&second.stdout, "Hooks directory", expected_hooks_directory),
+        "second setup run should include hooks directory '{}':\n{}",
+        expected_hooks_directory.display(),
+        second.stdout
+    );
 
     for hook in REQUIRED_HOOK_NAMES {
         let expected_hook_path = expected_hooks_directory.join(hook);
@@ -1448,9 +1444,7 @@ fn expected_agent_trace_local_db_path(harness: &SetupIntegrationHarness) -> Path
     #[cfg(target_os = "windows")]
     {
         harness
-            .home_dir
-            .join("AppData")
-            .join("Local")
+            .state_home
             .join("sce")
             .join("agent-trace")
             .join("local.db")
@@ -1477,6 +1471,32 @@ fn expected_agent_trace_local_db_path(harness: &SetupIntegrationHarness) -> Path
     }
 }
 
+fn stdout_contains_path_line(stdout: &str, label: &str, path: &Path) -> bool {
+    candidate_path_strings(path).into_iter().any(|candidate| {
+        stdout.contains(&format!("{label}: '{candidate}'"))
+            || stdout.contains(&format!("{label}: \"{candidate}\""))
+    })
+}
+
+fn candidate_path_strings(path: &Path) -> Vec<String> {
+    let raw = path.display().to_string();
+    let slash = raw.replace('\\', "/");
+    let raw_trimmed = trim_windows_verbatim_prefix(&raw).to_string();
+    let slash_trimmed = trim_windows_verbatim_prefix(&slash).to_string();
+
+    let mut candidates = vec![raw, slash, raw_trimmed, slash_trimmed];
+    candidates.sort();
+    candidates.dedup();
+    candidates
+}
+
+fn trim_windows_verbatim_prefix(value: &str) -> &str {
+    value
+        .strip_prefix(r"\\?\")
+        .or_else(|| value.strip_prefix("//?/"))
+        .unwrap_or(value)
+}
+
 fn null_device_path() -> &'static str {
     #[cfg(windows)]
     {