Skip to content

Commit 7cd0014

Browse files
Altruistusclaude
andcommitted
CM-71972: Name the home fixture without the underscore prefix
An underscore prefix marks a fixture as side-effect-only, and ruff's PT019 asks for usefixtures in that case. This one returns the scratch home the skill tests write into, so the value is used and the name should say so. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 88d4018 commit 7cd0014

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

tests/cli/commands/ai_guardrails/test_session_start_command.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def _isolated_session_context_cache(tmp_path: Path, monkeypatch: pytest.MonkeyPa
3232

3333

3434
@pytest.fixture(autouse=True)
35-
def _isolated_home(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
35+
def isolated_home(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
3636
"""Point every home-relative lookup at a scratch directory.
3737
3838
The skills sweep walks the filesystem rather than going through a collector these tests
@@ -632,15 +632,15 @@ def test_reports_skill_files(
632632
mock_collect: MagicMock,
633633
mock_load_config: MagicMock,
634634
mock_ctx: MagicMock,
635-
_isolated_home: Path,
635+
isolated_home: Path,
636636
) -> None:
637637
"""User-scope skills ride alongside the MCP inventory in the same report."""
638638
mock_get_auth.return_value = MagicMock(tenant_id='tenant-1')
639639
mock_ai_client = MagicMock()
640640
mock_get_client.return_value = mock_ai_client
641641
mock_collect.return_value = ({}, {})
642642
content = '---\nname: dummy-skill\n---\nBody.\n'
643-
skill_file = _write_claude_skill(_isolated_home, 'dummy-skill', content)
643+
skill_file = _write_claude_skill(isolated_home, 'dummy-skill', content)
644644
skills = [{'path': str(skill_file), 'content': content}]
645645

646646
payload = {'session_id': 'session-123'}
@@ -671,7 +671,7 @@ def test_editing_a_skill_re_reports(
671671
mock_collect: MagicMock,
672672
mock_load_config: MagicMock,
673673
mock_ctx: MagicMock,
674-
_isolated_home: Path,
674+
isolated_home: Path,
675675
) -> None:
676676
"""Skill bodies are part of the dedup digest, so an edit sends a fresh report."""
677677
mock_get_auth.return_value = MagicMock(tenant_id='tenant-1')
@@ -680,7 +680,7 @@ def test_editing_a_skill_re_reports(
680680
mock_collect.return_value = ({}, {})
681681
payload = json.dumps({'session_id': 'session-123'})
682682

683-
_write_claude_skill(_isolated_home, 'dummy-skill', 'first')
683+
_write_claude_skill(isolated_home, 'dummy-skill', 'first')
684684
with patch('sys.stdin', new=StringIO(payload)):
685685
session_start_command(mock_ctx, ide='claude-code')
686686

@@ -689,7 +689,7 @@ def test_editing_a_skill_re_reports(
689689
session_start_command(mock_ctx, ide='claude-code')
690690
assert mock_ai_client.report_session_context.call_count == 1
691691

692-
_write_claude_skill(_isolated_home, 'dummy-skill', 'edited')
692+
_write_claude_skill(isolated_home, 'dummy-skill', 'edited')
693693
with patch('sys.stdin', new=StringIO(payload)):
694694
session_start_command(mock_ctx, ide='claude-code')
695695
assert mock_ai_client.report_session_context.call_count == 2

0 commit comments

Comments
 (0)