From 6a0a84fe3a9ab38f2ac43ceb3e6b439d96f017ba Mon Sep 17 00:00:00 2001 From: Nelson Parente Date: Tue, 20 Oct 2026 12:35:51 +0200 Subject: [PATCH] ci: verify golangci-lint config only on pull requests golangci-lint-action runs `golangci-lint config verify` before it lints. That step downloads the config JSON schema from golangci-lint.run. When the download fails, the job fails and the linter does not run. The push build of the v0.19.0 commit on main failed this way (run 38934087081). Verify the config only on pull requests, as dapr/dapr#10755 does. Config changes land through pull requests. Pushes still run the linter with the same rules. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Nelson Parente --- .github/workflows/kit.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/kit.yml b/.github/workflows/kit.yml index fcd1004..91bb25e 100644 --- a/.github/workflows/kit.yml +++ b/.github/workflows/kit.yml @@ -54,6 +54,10 @@ jobs: with: version: ${{ env.GOLANGCI_LINT_VER }} skip-cache: true + # Verifying the config downloads its JSON schema from golangci-lint.run, + # which sometimes fails on push. Config changes land through PRs, so + # verifying there is enough. + verify: ${{ github.event_name == 'pull_request' }} - name: Run make go.mod check-diff if: matrix.target_arch != 'arm' run: make go.mod check-diff