Skip to content

Commit 18ee36f

Browse files
ai: apply changes for #463 (1 review thread)
Addresses: - #3715785609 at lib/DBSQLClient.ts:240 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent ecee476 commit 18ee36f

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

lib/contracts/IDBSQLClient.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,17 @@ export type ConnectionOptions = {
7777

7878
/**
7979
* PEM-encoded CA certificate (string or `Buffer`) added to the trust store
80-
* **on top of** the system roots — for TLS-inspecting proxies or on-prem
80+
* **on top of** the built-in roots — for TLS-inspecting proxies or on-prem
8181
* internal CAs. Because it is additive, connections to public Databricks
82-
* warehouses (trusted via the system roots) keep working. Roots supplied via
83-
* the `NODE_EXTRA_CA_CERTS` environment variable are also preserved.
82+
* warehouses keep working.
83+
*
84+
* Note: supplying this rebuilds the trust store from Node's **bundled Mozilla
85+
* roots** (`tls.rootCertificates`) plus any roots from the `NODE_EXTRA_CA_CERTS`
86+
* environment variable, then appends this certificate. It does **not** include
87+
* OS-installed roots that Node would otherwise consult (e.g. on Node >= 22 run
88+
* with `--use-system-ca`). If you rely on an enterprise root installed in the
89+
* OS trust store, add it explicitly via `NODE_EXTRA_CA_CERTS` or `customCaCert`
90+
* when using this option.
8491
*
8592
* Mirrors the `customCaCert` option on the SEA backend.
8693
*/

0 commit comments

Comments
 (0)