Skip to content

Commit 6fdff86

Browse files
ci: broaden coverage-fanout source filter beyond lib/
The isSource predicate only matched lib/, but driver source also lives at native/ (kernel bindings), thrift/ (Thrift defs), and the KERNEL_REV pin. A merged PR that only bumped KERNEL_REV or edited native/ or thrift/ would report srcChanged=false and never dispatch coverage-fanout, even though it affects the Thrift/kernel backends — the same gap the "run on every change" comments in this workflow already document. Include those roots. Co-authored-by: Isaac Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
1 parent 15ab3eb commit 6fdff86

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/trigger-integration-tests.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -327,9 +327,13 @@ jobs:
327327
pull_number: context.payload.pull_request.number,
328328
per_page: 100,
329329
});
330-
// The whole repo IS the driver. Count a merge as source-affecting when it changes a file under lib/.
331-
// Docs/CI/test-only merges do not warrant a full multi-language fan-out.
332-
const isSource = (f) => f.startsWith('lib/');
330+
// The whole repo IS the driver. Count a merge as source-affecting when it changes driver
331+
// source: lib/ (JS/TS), native/ (kernel bindings), thrift/ (Thrift defs), or the KERNEL_REV
332+
// pin. Docs/CI/test-only merges do not warrant a full multi-language fan-out. (Matches the
333+
// source roots called out in the "run on every change" comments above — a merge that only
334+
// bumps KERNEL_REV or edits native/ or thrift/ still affects the Thrift/kernel backends.)
335+
const isSource = (f) =>
336+
f.startsWith('lib/') || f.startsWith('native/') || f.startsWith('thrift/') || f === 'KERNEL_REV';
333337
const srcChanged = files.some((f) => isSource(f.filename));
334338
console.log(`driver source changed: ${srcChanged}`);
335339
core.setOutput('source', srcChanged.toString());

0 commit comments

Comments
 (0)