Skip to content

Commit 7f4a972

Browse files
ai: apply changes for #457 (1 review thread)
Addresses: - #3799637110 at CONNECTION_PARAMETERS.md:76 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent ec26f9a commit 7f4a972

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

CONNECTION_PARAMETERS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ column.
7373
| `socketTimeout` | `number` (ms) || ⚠️ | `900000` (15 min) | Kernel maps it to the request timeout but forwards **only positive** values — `socketTimeout: 0` (Thrift "wait indefinitely") is omitted so the kernel keeps its large default. |
7474
| `proxy` | `ProxyOptions` || ⚠️ || `{protocol, host, port, auth}`. Kernel accepts **`http://` / `https://` only**; a SOCKS `protocol` surfaces a kernel connect error (Thrift supports SOCKS variants). |
7575
| `noProxy` (internal) | `string` |||| **Thrift ignores `noProxy`**`getConnectionOptions` never threads it, and `getProxyForUrl: () => proxyUrl` returns the proxy for every URL (no bypass-list logic). Only the kernel honors it, forwarded as `bypassHosts`. |
76-
| `customHeaders` | `Record<string, string>` | ||| Kernel drops reserved `Authorization` / `x-databricks-org-id`, rejects CR/LF/NUL, and appends the connector `User-Agent` last. |
76+
| `customHeaders` | `Record<string, string>` | ⚠️ ||| **Thrift: out-of-band requests only.** `getConnectionOptions` never threads `customHeaders` into the Thrift query transport (it sets only `User-Agent`); the map is consumed by `buildCustomHeaders` for driver-owned telemetry POSTs / feature-flag GETs and SPOG `x-databricks-org-id` injection, not the primary transport or OAuth/OIDC token requests. Kernel applies them to every request (dropping reserved `Authorization` / `x-databricks-org-id`, rejecting CR/LF/NUL, appending the connector `User-Agent` last). |
7777
| `retryMaxAttempts` | `number` ||| `5` | Total-attempt semantics on both; kernel converts to retries-after-first. |
7878
| `retriesTimeout` | `number` (ms) ||| `900000` (15 min) | Kernel converts ms → whole seconds. |
7979
| `retryDelayMin` | `number` (ms) ||| `1000` (1 s) | Kernel converts ms → seconds. |

0 commit comments

Comments
 (0)