Skip to content

Commit 78eb536

Browse files
committed
refactor(kernel): pass request timeout directly
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
1 parent f19a5ea commit 78eb536

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

src/databricks/sql/backend/kernel/client.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,11 +332,6 @@ def open_session(
332332
# Translate the connector's ``_retry_*`` kwargs into the
333333
# kernel's ``retry_*`` kwargs. Empty when at defaults.
334334
retry_kwargs = _kernel_retry_kwargs(self._retry_options)
335-
request_timeout_kwargs: Dict[str, Any] = {}
336-
if self._request_timeout_secs is not None:
337-
request_timeout_kwargs["request_timeout_secs"] = (
338-
self._request_timeout_secs
339-
)
340335
# Forward caller / connector HTTP headers. The kernel applies
341336
# them on every request; a caller ``User-Agent`` is appended
342337
# to the kernel's base UA. Only pass the kwarg when there's
@@ -376,10 +371,10 @@ def open_session(
376371
# backend's surface (interval columns arrive as
377372
# strings).
378373
intervals_as_string=True,
374+
request_timeout_secs=self._request_timeout_secs,
379375
**auth_kwargs,
380376
**tls_kwargs,
381377
**retry_kwargs,
382-
**request_timeout_kwargs,
383378
**http_headers_kwargs,
384379
)
385380
except Exception as exc:

tests/unit/test_kernel_client.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,10 +365,7 @@ def fake_session(**kw):
365365

366366
c.open_session(session_configuration=None, catalog=None, schema=None)
367367

368-
if timeout is None:
369-
assert "request_timeout_secs" not in captured
370-
else:
371-
assert captured["request_timeout_secs"] == timeout
368+
assert captured["request_timeout_secs"] == timeout
372369

373370

374371
def test_execute_command_forwards_parameters_to_bind_param():

0 commit comments

Comments
 (0)