Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d689dfc78a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {trigger} | ||
| </DropdownMenu.Trigger> | ||
| <DropdownMenu.Portal container={portalContainer ?? undefined}> | ||
| <DropdownMenu.Content |
There was a problem hiding this comment.
When a keyboard user presses Tab or Shift+Tab from an open dropdown, Radix Menu.Content prevents the browser's default Tab action and does not close the menu. With no Tab override here, focus remains on the current item; the replaced implementation explicitly closed the menu, returned focus to the trigger, and allowed Tab to continue. Restore an explicit Tab exit path so users can navigate past dropdowns in either direction.
Useful? React with 👍 / 👎.
d689dfc to
eb92d18
Compare
This branch has not been deployed
1 participant
Disabled entries before a selected dropdown item changed the index used to focus the rendered menu, so opening or hovering could focus a different action. The custom menu also maintained its own keyboard loop, portal positioning, animation polling, and dismissal listeners.
This replaces those mechanics with a thin Radix Dropdown Menu wrapper while retaining Pane's trigger/item styles, checked selection, disabled actions, footer controls, keep-open selection, portal containers, and trigger-width menus. Initial focus uses the selected element directly. Footer actions join the framework's focus collection. A dialog opened by a menu action restores focus to the persistent menu trigger through its ARIA association; the selected menu item is transient.
The unused navigation module and its 12 pure-helper tests are removed. Rendered Playwright checks cover the former failure, pointer/keyboard agreement, disabled selection, wrapping, Home/End, footer activation, Escape/focus return, outside dismissal, and full width. The dropdown spec is now included in maintained CI smoke coverage.
Supply chain: pin
@radix-ui/react-dropdown-menu@2.1.15(published 2025-05-20) to match the existing Radix primitive versions. The lock adds only Dropdown Menu, Menu, and Roving Focus; all are MIT and have no install lifecycle scripts. Every existing locked package and snapshot stays unchanged. The seven-day age floor and build-script allowlist remain intact.NOTICESadds the three regenerated attribution entries.Built verification also reproduced #635: an unavailable Google Fonts stylesheet rejected Vite's CSS preload and prevented the renderer from mounting. The external import is removed, using the existing local font fallback stack.
Validation:
pnpm install --frozen-lockfile --offline --ignore-scriptspnpm lintandpnpm typecheckpnpm build:frontend, including xterm and React Scan build guardsCloses #618.
Closes #635.