Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
parsakhaz
force-pushed
the
codex/audit-analytics
branch
from
September 27, 2026 08:01
fc22573 to
819b9f6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pane's default PostHog entry downloaded executable
config.jsand could lazy-load extensions outside the reviewed lockfile graph. This bypassed the supply chain guarantees of the packaged application.This PR uses the installed SDK's supported
module.no-externalentry and enablesdisable_external_dependency_loading. Remote configuration remains JSON data; analytics capture, identity, attribution, consent defaults, and explicit opt-out retain their existing behavior. No dependencies or lockfiles change.The maintained analytics browser journey now verifies actual SDK identity and interaction payloads, alongside the existing first-open and opt-out markers. It advertises remote replay, surveys, and exception features and rejects every external script request. The opt-out test waits for Privacy Settings and rejects each forbidden event individually, replacing its weak 250 ms timing check. Both cases are included in CI.
Validation:
pnpm lintandpnpm typecheckwith repository-pinned pnpm 10.19.Frontend production build, including xterm and React Scan build guards.
Analytics browser journeys against Vite dev and production preview: 2/2 passing in each.
Negative control: restoring the original loading behavior fails the same network assertion on
config.js,lazy-recorder.js,surveys.js, andexception-autocapture.js.Closes #640