diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6cf951b..c80e7c4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -185,6 +185,7 @@ jobs: pattern: desktop-* - name: Upload bundles to the draft release env: + GH_REPO: ${{ github.repository }} GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} RELEASE_TAG: ${{ fromJSON(needs.changepacks.outputs.pending_releases)['package.json'].tagName }} shell: bash diff --git a/tests/ci/release-workflow.test.ts b/tests/ci/release-workflow.test.ts index 5322038..ff3d01f 100644 --- a/tests/ci/release-workflow.test.ts +++ b/tests/ci/release-workflow.test.ts @@ -130,6 +130,9 @@ describe('desktop release workflow', () => { const finalizeStep = finalizeJob.steps?.find((step) => step.uses?.startsWith('changepacks/action@'), ) + const uploadReleaseStep = uploadJob.steps?.find((step) => + step.run?.includes('gh release upload'), + ) expect(uploadJob.needs).toEqual(['changepacks', 'release-desktop']) expect(uploadJob.permissions).toEqual({ contents: 'write' }) @@ -137,6 +140,7 @@ describe('desktop release workflow', () => { expect( uploadJob.steps?.some((step) => step.run?.includes('gh release upload')), ).toBe(true) + expect(uploadReleaseStep?.env?.GH_REPO).toBe('${{ github.repository }}') expect(finalizeJob.needs).toEqual(['changepacks', 'upload-release']) expect(finalizeStep?.with?.finalize_releases).toBe( '${{ needs.changepacks.outputs.pending_releases }}',