Repository navigation
feat(device): bundle only the files a directory's flows use - #275
Merged
Merged
Conversation
`dcd device run <dir>` and the MCP `run` tool's `path` zipped every file in the directory. A samples folder with builds next to its flows sent all of them, so an agent copied the flow, scripts and subflows to a temp folder by hand. A bundle now holds every YAML file (flows, subflows, config), the files the flows use (runScript, addMedia, assertScreenshot and the like, found the way `dcd cloud` finds them), and config's includedPaths. Nothing else. With an entry flow (`--entry`, or the MCP `flow` input), only its files must exist; another flow's missing file doesn't stop it. Without one, every flow's must. A file outside the directory is an error that names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dcd device run <dir>and the MCPruntool'spathinput zipped every file in the directory. In a samples folder with app builds next to the flows, that meant uploading all the builds just to run a few YAML files. The workaround was to copy the flow, scripts and subflows into a temp folder by hand.What
bundleFiles(dir, entry?)now picks:runFlow,runScript,addMedia,assertScreenshotand so on, found with the sameprocessDependenciesthatdcd cloudusesconfig.yaml'sincludedPaths(now exported from the execution-plan service)Nothing else goes in. Dot-folders and
node_modulesstay out, as before.How missing files are handled:
--entry, or the MCPflowinput): the entry's files must exist. A broken file in some other flow doesn't block the entry.The MCP bridge passes
flowthrough as the entry. Itspathdescription now says only flows and the files they use are uploaded.Checks
typecheckandbuildare clean.lintreports the same 24 warnings as before, and no new ones.🤖 Generated with Claude Code