Repository navigation
feat(api): send the CLI version and CI identity on every API request - #277
Merged
Merged
Conversation
x-dcd-cli-version, x-dcd-ci-provider and x-dcd-ci-wrapper-version were only sent on the compatibility call, for notices. resolveAuth now puts them on every auth context, so every gateway sends them. The API records them on each upload and binary, and on its HTTP log line, so it can tell which CLIs and CI wrappers still use an endpoint before it is retired. fetchCompatibilityData loses its client-context argument, since the auth headers carry the same values. MCP calls now send them too. Refs dcd#1622
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
Correction to my inline comment: the CLAUDE.md link there points at the wrong lines. The rule against private-repo issue numbers is on CLAUDE.md L64. |
Fix comment formatting in auth test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-dcd-cli-version, x-dcd-ci-provider and x-dcd-ci-wrapper-version were only sent on the compatibility call, for notices. resolveAuth now puts them on every auth context, so every gateway sends them. The API records them on each upload and binary, and on its HTTP log line, so it can tell which CLIs and CI wrappers still use an endpoint before it is retired.
fetchCompatibilityData loses its client-context argument, since the auth headers carry the same values. MCP calls now send them too.
Refs dcd#1622
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test