From acd42add322be281f232aed6ce9676390d548ea3 Mon Sep 17 00:00:00 2001
From: Daniel Cazzulino <daniel@cazzulino.com>
Date: Fri, 28 Aug 2026 22:14:12 -0300
Subject: [PATCH] Suppress payload pack NU* analysis noise

---
 src/Azure.Cli/Azure.Cli.pack.targets |  1 -
 src/Directory.props                  | 11 ++++++++++-
 src/Tests/PackTests.cs               |  5 +++++
 src/azx/azx.csproj                   |  1 -
 4 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/Azure.Cli/Azure.Cli.pack.targets b/src/Azure.Cli/Azure.Cli.pack.targets
index d445e2c..ca6395a 100644
--- a/src/Azure.Cli/Azure.Cli.pack.targets
+++ b/src/Azure.Cli/Azure.Cli.pack.targets
@@ -2,7 +2,6 @@
   <!-- Pointer vs RID pack. Imported only by Azure.Cli.csproj; not shipped. -->
   <PropertyGroup>
     <AzureCliPackageId Condition="'$(AzureCliPackageId)' == ''">$(PackageId)</AzureCliPackageId>
-    <NoWarn>$(NoWarn);NU5100;NU5110;NU5111;NU5118;NU5119;NU5128;NU5129</NoWarn>
     <IncludeBuildOutput Condition="'$(RuntimeIdentifier)' == ''">true</IncludeBuildOutput>
     <IncludeBuildOutput Condition="'$(RuntimeIdentifier)' != ''">false</IncludeBuildOutput>
     <SuppressDependenciesWhenPacking Condition="'$(RuntimeIdentifier)' != ''">true</SuppressDependenciesWhenPacking>
diff --git a/src/Directory.props b/src/Directory.props
index 51e14f2..cbc2081 100644
--- a/src/Directory.props
+++ b/src/Directory.props
@@ -2,5 +2,14 @@
   <PropertyGroup>
     <Product>azx</Product>
     <ImplicitUsings>true</ImplicitUsings>
+    <!--
+      Pack analysis assumes a typical .NET library. The Azure CLI Payload and PackAsTool
+      host trip these constantly and none of them are actionable:
+      NU5100 assemblies outside lib/, NU5110/NU5111 .ps1 files that are not NuGet install
+      scripts (azps.ps1, Activate.ps1), NU5118/NU5119 payload collisions and dotfiles,
+      NU5123 paths > 200 chars in the CLI tree, NU5128/NU5129 TFM/lib and build/.targets
+      naming that do not apply to RID/tool packs.
+    -->
+    <NoWarn>$(NoWarn);NU5100;NU5110;NU5111;NU5118;NU5119;NU5123;NU5128;NU5129</NoWarn>
   </PropertyGroup>
-</Project>
\ No newline at end of file
+</Project>
diff --git a/src/Tests/PackTests.cs b/src/Tests/PackTests.cs
index f01d65c..ff50b50 100644
--- a/src/Tests/PackTests.cs
+++ b/src/Tests/PackTests.cs
@@ -64,6 +64,10 @@ public void Pointer_and_rid_csproj_use_pack_split()
         Assert.Contains("$(AzureCliPackageId).$(RuntimeIdentifier)", packTargets);
         Assert.DoesNotContain("runtimes/$(RuntimeIdentifier)/native/", packTargets);
 
+        var directoryProps = File.ReadAllText(Path.Combine(repo, "src", "Directory.props"));
+        Assert.Contains("NU5100;NU5110;NU5111;NU5118;NU5119;NU5123;NU5128;NU5129", directoryProps);
+        Assert.DoesNotContain("<NoWarn>", packTargets);
+
         var consumer = File.ReadAllText(Path.Combine(repo, "src", "Azure.Cli", "buildTransitive", "azx.cli.targets"));
         Assert.Contains("IncludeAzureCliPayload", consumer);
         Assert.Contains(@"TargetPath>az\", consumer.Replace('/', '\\'));
@@ -77,6 +81,7 @@ public void Pointer_and_rid_csproj_use_pack_split()
         Assert.Contains("<ToolPackageRuntimeIdentifiers>win-x64;linux-x64;linux-arm64;osx-x64;osx-arm64</ToolPackageRuntimeIdentifiers>", azx);
         Assert.Contains("""<PackageReference Include="azx.cli" Version="$(Version)" />""", azx);
         Assert.DoesNotContain("NuGetizer", azx, StringComparison.OrdinalIgnoreCase);
+        Assert.DoesNotContain("<NoWarn>", azx);
         Assert.Contains("Readme", azx);
         var nuget = File.ReadAllText(Path.Combine(repo, "src", "azx", "nuget.config"));
         Assert.Contains("key=\"local\"", nuget);
diff --git a/src/azx/azx.csproj b/src/azx/azx.csproj
index cf2242f..1800a98 100644
--- a/src/azx/azx.csproj
+++ b/src/azx/azx.csproj
@@ -11,7 +11,6 @@
     <ToolCommandName>azx</ToolCommandName>
     <ToolPackageRuntimeIdentifiers>win-x64;linux-x64;linux-arm64;osx-x64;osx-arm64</ToolPackageRuntimeIdentifiers>
     <IsPackable>true</IsPackable>
-    <NoWarn>$(NoWarn);NU5128</NoWarn>
     <RestoreSources>https://api.nuget.org/v3/index.json</RestoreSources>
     <RestoreSources Condition="Exists('$(PackageOutputPath)')">$(PackageOutputPath);$(RestoreSources)</RestoreSources>
     <RestoreIgnoreFailedSources>true</RestoreIgnoreFailedSources>