diff --git a/cmd/env_flags_test.go b/cmd/env_flags_test.go index daf7ba61c0..19e76c2734 100644 --- a/cmd/env_flags_test.go +++ b/cmd/env_flags_test.go @@ -23,7 +23,7 @@ const ( // setting the corresponding DEVSY_* env var pushes the value into the bound // pflag at registration time, satisfying cobra's required-flag check. func TestOptInEnvFlags_AppliesEnvValueToFlag(t *testing.T) { - t.Setenv(envProEnabled, "true") + t.Setenv(envPlatformEnabled, "true") cases := []struct { cmdPath string flagName string @@ -94,7 +94,7 @@ func TestOptInEnvFlags_NoEnvLeavesDefault(t *testing.T) { // BindEnv: setting DEVSY_HOST="" must NOT mark the flag as Changed (otherwise // MarkFlagRequired would be satisfied by an empty value). func TestOptInEnvFlags_EmptyEnvIsNoOp(t *testing.T) { - t.Setenv(envProEnabled, "true") + t.Setenv(envPlatformEnabled, "true") t.Setenv(envDevsyHost, "") rootCmd, _ := BuildRoot() cmd := resolveCommand(t, rootCmd, "pro workspace list") @@ -107,7 +107,7 @@ func TestOptInEnvFlags_EmptyEnvIsNoOp(t *testing.T) { // wins over a value supplied via DEVSY_*. This is the standard precedence // users expect: flag > env > default. func TestOptInEnvFlags_CLIOverridesEnv(t *testing.T) { - t.Setenv(envProEnabled, "true") + t.Setenv(envPlatformEnabled, "true") t.Setenv(envDevsyHost, "env-value") rootCmd, _ := BuildRoot() // Replace the leaf command's RunE so Execute() doesn't try to actually @@ -125,7 +125,7 @@ func TestOptInEnvFlags_CLIOverridesEnv(t *testing.T) { } func TestOptInEnvFlags_EnvSatisfiesRequired(t *testing.T) { - t.Setenv(envProEnabled, "true") + t.Setenv(envPlatformEnabled, "true") t.Setenv(envDevsyHost, "from-env.example.com") rootCmd, _ := BuildRoot() leaf := resolveCommand(t, rootCmd, "pro workspace list") @@ -139,17 +139,17 @@ func TestOptInEnvFlags_EnvSatisfiesRequired(t *testing.T) { assert.Equal(t, "from-env.example.com", seen) } -// TestOptInEnvFlags_ProSubcommandSweep asserts that DEVSY_HOST applies to +// TestOptInEnvFlags_PlatformSubcommandSweep asserts that DEVSY_HOST applies to // every pro subcommand that exposes --host (and similarly for --project). // This catches the regression where a future addition to cmd/pro/ forgets // the inline BindEnv call. -func TestOptInEnvFlags_ProSubcommandSweep(t *testing.T) { - t.Setenv(envProEnabled, "true") +func TestOptInEnvFlags_PlatformSubcommandSweep(t *testing.T) { + t.Setenv(envPlatformEnabled, "true") for _, env := range []string{envDevsyHost, envDevsyProject} { t.Setenv(env, "sweep-"+strings.ToLower(env)) } rootCmd, _ := BuildRoot() - proCmd := resolveCommand(t, rootCmd, "pro") + platformCmd := resolveCommand(t, rootCmd, "pro") var walk func(c *cobra.Command) walk = func(c *cobra.Command) { @@ -165,12 +165,12 @@ func TestOptInEnvFlags_ProSubcommandSweep(t *testing.T) { walk(child) } } - walk(proCmd) + walk(platformCmd) } -// TestProCommand_HiddenWhenDisabled verifies pro is gated off by default. -func TestProCommand_HiddenWhenDisabled(t *testing.T) { - t.Setenv(envProEnabled, "") +// TestPlatformCommand_HiddenWhenDisabled verifies pro is gated off by default. +func TestPlatformCommand_HiddenWhenDisabled(t *testing.T) { + t.Setenv(envPlatformEnabled, "") rootCmd, _ := BuildRoot() for _, c := range rootCmd.Commands() { use := c.Use diff --git a/cmd/pro/list.go b/cmd/pro/list.go index fc6670d7b3..3d94c6f34c 100644 --- a/cmd/pro/list.go +++ b/cmd/pro/list.go @@ -120,9 +120,9 @@ func (cmd *ListCmd) printJSON( devsyConfig *config.Config, platformInstances []*provider.PlatformInstance, ) error { - tableEntries := []*proTableEntry{} + tableEntries := []*platformTableEntry{} for _, platformInstance := range platformInstances { - entry := &proTableEntry{ + entry := &platformTableEntry{ PlatformInstance: platformInstance, Context: devsyConfig.DefaultContext, Capabilities: getCapabilities(devsyConfig, platformInstance), @@ -148,7 +148,7 @@ func (cmd *ListCmd) printJSON( return nil } -type proTableEntry struct { +type platformTableEntry struct { *provider.PlatformInstance Authenticated *bool `json:"authenticated,omitempty"` diff --git a/cmd/pro/login.go b/cmd/pro/login.go index 38c5dd5156..cc750d827e 100644 --- a/cmd/pro/login.go +++ b/cmd/pro/login.go @@ -245,7 +245,7 @@ func findInstance( func (cmd *LoginCmd) resolveNewProviderName(devsyConfig *config.Config, host string) error { if cmd.Provider == "" { - cmd.Provider = config.ProReleaseName + cmd.Provider = config.PlatformReleaseName } cmd.Provider = provider.ToPlatformInstanceID(cmd.Provider) diff --git a/cmd/pro/login_test.go b/cmd/pro/login_test.go index e88feb7957..065436feae 100644 --- a/cmd/pro/login_test.go +++ b/cmd/pro/login_test.go @@ -12,7 +12,7 @@ import ( "github.com/stretchr/testify/suite" ) -const testProProviderName = "pro" +const testPlatformProviderName = "pro" type loginSuite struct { suite.Suite @@ -58,12 +58,12 @@ func (s *loginSuite) TestConcurrentLoginFindsCreatedInstance() { } s.Require().NoError(provider.SavePlatformInstanceConfig("default", &provider.PlatformInstance{ - Provider: testProProviderName, + Provider: testPlatformProviderName, Host: "pro.example", })) s.Require().NoError(lock.Unlock()) s.Require().NoError(<-result) - s.Equal(testProProviderName, cmd.Provider) + s.Equal(testPlatformProviderName, cmd.Provider) } func (s *loginSuite) TestDifferentHostDoesNotWaitForLoginLock() { @@ -114,18 +114,18 @@ func (s *loginSuite) TestEquivalentHostsShareLock() { func (s *loginSuite) TestEquivalentHostFindsExistingInstance() { s.Require().NoError(provider.SavePlatformInstanceConfig("default", &provider.PlatformInstance{ - Provider: testProProviderName, + Provider: testPlatformProviderName, Host: "Foo.Example.com", })) cmd := &LoginCmd{GlobalFlags: proflags.GlobalFlags{GlobalFlags: &rootflags.GlobalFlags{}}} _, err := cmd.prepareProvider(context.Background(), "https://foo.example.com") s.Require().NoError(err) - s.Equal(testProProviderName, cmd.Provider) + s.Equal(testPlatformProviderName, cmd.Provider) } func (s *loginSuite) TestDistinctHostsWithSameInstanceIDAreRejected() { s.Require().NoError(provider.SavePlatformInstanceConfig("default", &provider.PlatformInstance{ - Provider: testProProviderName, + Provider: testPlatformProviderName, Host: "foo.example.com", })) cmd := &LoginCmd{GlobalFlags: proflags.GlobalFlags{GlobalFlags: &rootflags.GlobalFlags{}}} diff --git a/cmd/pro/pro.go b/cmd/pro/pro.go index 80eff75cff..d277351152 100644 --- a/cmd/pro/pro.go +++ b/cmd/pro/pro.go @@ -13,10 +13,10 @@ import ( "github.com/spf13/cobra" ) -// NewProCmd returns a new command. -func NewProCmd(flags *flags.GlobalFlags) *cobra.Command { +// NewPlatformCmd returns a new command. +func NewPlatformCmd(flags *flags.GlobalFlags) *cobra.Command { globalFlags := &proflags.GlobalFlags{GlobalFlags: flags} - proCmd := &cobra.Command{ + platformCmd := &cobra.Command{ Use: "pro", Short: "Devsy Pro commands", SilenceUsage: true, @@ -28,22 +28,22 @@ func NewProCmd(flags *flags.GlobalFlags) *cobra.Command { }, } - proCmd.AddCommand(NewLoginCmd(globalFlags)) - proCmd.AddCommand(NewLogoutCmd(globalFlags)) - proCmd.AddCommand(NewListCmd(globalFlags)) - proCmd.AddCommand(NewStartCmd(globalFlags)) - proCmd.AddCommand(NewSelfCmd(globalFlags)) - proCmd.AddCommand(NewVersionCmd(globalFlags)) - proCmd.AddCommand(NewHealthCmd(globalFlags)) - proCmd.AddCommand(NewCheckUpdateCmd(globalFlags)) - proCmd.AddCommand(NewUpdateProviderCmd(globalFlags)) + platformCmd.AddCommand(NewLoginCmd(globalFlags)) + platformCmd.AddCommand(NewLogoutCmd(globalFlags)) + platformCmd.AddCommand(NewListCmd(globalFlags)) + platformCmd.AddCommand(NewStartCmd(globalFlags)) + platformCmd.AddCommand(NewSelfCmd(globalFlags)) + platformCmd.AddCommand(NewVersionCmd(globalFlags)) + platformCmd.AddCommand(NewHealthCmd(globalFlags)) + platformCmd.AddCommand(NewCheckUpdateCmd(globalFlags)) + platformCmd.AddCommand(NewUpdateProviderCmd(globalFlags)) - proCmd.AddCommand(procluster.NewClusterCmd(globalFlags)) - proCmd.AddCommand(proproject.NewProjectCmd(globalFlags)) - proCmd.AddCommand(protemplate.NewTemplateCmd(globalFlags)) - proCmd.AddCommand(prouser.NewUserCmd(globalFlags)) - proCmd.AddCommand(proworkspace.NewWorkspaceCmd(globalFlags)) - proCmd.AddCommand(daemon.NewCmd(globalFlags)) - proCmd.AddCommand(provider.NewProProviderCmd(globalFlags)) - return proCmd + platformCmd.AddCommand(procluster.NewClusterCmd(globalFlags)) + platformCmd.AddCommand(proproject.NewProjectCmd(globalFlags)) + platformCmd.AddCommand(protemplate.NewTemplateCmd(globalFlags)) + platformCmd.AddCommand(prouser.NewUserCmd(globalFlags)) + platformCmd.AddCommand(proworkspace.NewWorkspaceCmd(globalFlags)) + platformCmd.AddCommand(daemon.NewCmd(globalFlags)) + platformCmd.AddCommand(provider.NewPlatformProviderCmd(globalFlags)) + return platformCmd } diff --git a/cmd/pro/proutil/proutil.go b/cmd/pro/proutil/proutil.go index 468ded2889..0cee58a2d0 100644 --- a/cmd/pro/proutil/proutil.go +++ b/cmd/pro/proutil/proutil.go @@ -23,9 +23,9 @@ const ( HeaderDisplayName = "Display Name" ) -// FindProProvider resolves the devsy config and provider config for the given +// FindPlatformProvider resolves the devsy config and provider config for the given // pro host. -func FindProProvider( +func FindPlatformProvider( ctx context.Context, context, provider, host string, ) (*config.Config, *providerpkg.ProviderConfig, error) { @@ -50,9 +50,9 @@ type HostRunFunc func( provider *providerpkg.ProviderConfig, ) error -// findProProviderFn is FindProProvider behind a variable so HostRunE tests can +// findPlatformProviderFn is FindPlatformProvider behind a variable so HostRunE tests can // stub provider resolution. -var findProProviderFn = FindProProvider +var findPlatformProviderFn = FindPlatformProvider // HostRunE returns a RunE that resolves the provider for *host and passes it to // run. *host is read when the command runs, after flag parsing. @@ -63,7 +63,7 @@ func HostRunE( ) func(*cobra.Command, []string) error { return func(cobraCmd *cobra.Command, _ []string) error { ctx := cobraCmd.Context() - devsyConfig, pCfg, err := findProProviderFn( + devsyConfig, pCfg, err := findPlatformProviderFn( ctx, globalFlags.Context, globalFlags.Provider, diff --git a/cmd/pro/proutil/proutil_test.go b/cmd/pro/proutil/proutil_test.go index c55a85f051..e0d3785538 100644 --- a/cmd/pro/proutil/proutil_test.go +++ b/cmd/pro/proutil/proutil_test.go @@ -70,13 +70,13 @@ func (s *hostFlagSuite) TestFlagValueSetsDest() { } func (s *hostFlagSuite) TestHostRunEResolvesHostAtRunTime() { - orig := findProProviderFn - s.T().Cleanup(func() { findProProviderFn = orig }) + orig := findPlatformProviderFn + s.T().Cleanup(func() { findPlatformProviderFn = orig }) var gotContext, gotProvider, gotHost string devsyConfig := &config.Config{} pCfg := &providerpkg.ProviderConfig{Name: "p"} - findProProviderFn = func( + findPlatformProviderFn = func( _ context.Context, ctxName, providerName, host string, ) (*config.Config, *providerpkg.ProviderConfig, error) { @@ -110,11 +110,11 @@ func (s *hostFlagSuite) TestHostRunEResolvesHostAtRunTime() { } func (s *hostFlagSuite) TestHostRunEPropagatesResolveErrorWithoutRunning() { - orig := findProProviderFn - s.T().Cleanup(func() { findProProviderFn = orig }) + orig := findPlatformProviderFn + s.T().Cleanup(func() { findPlatformProviderFn = orig }) boom := errors.New("resolve failed") - findProProviderFn = func( + findPlatformProviderFn = func( context.Context, string, string, string, ) (*config.Config, *providerpkg.ProviderConfig, error) { diff --git a/cmd/pro/provider/provider.go b/cmd/pro/provider/provider.go index 4bb1fc138e..4d184f7a3c 100644 --- a/cmd/pro/provider/provider.go +++ b/cmd/pro/provider/provider.go @@ -15,8 +15,8 @@ import ( "github.com/spf13/cobra" ) -// NewProProviderCmd creates a new cobra command. -func NewProProviderCmd(globalFlags *flags.GlobalFlags) *cobra.Command { +// NewPlatformProviderCmd creates a new cobra command. +func NewPlatformProviderCmd(globalFlags *flags.GlobalFlags) *cobra.Command { c := &cobra.Command{ Use: "provider", Short: "Devsy Pro provider commands", diff --git a/cmd/pro/start.go b/cmd/pro/start.go index 5642636fa1..58b12258a3 100644 --- a/cmd/pro/start.go +++ b/cmd/pro/start.go @@ -51,7 +51,7 @@ const ( trueString = "true" ) -var defaultReleaseName = config.ProReleaseName +var defaultReleaseName = config.PlatformReleaseName var defaultDeploymentName = "loft" // Need to update helm chart if we change this! @@ -89,8 +89,8 @@ type StartCmd struct { func NewStartCmd(flags *proflags.GlobalFlags) *cobra.Command { cmd := &StartCmd{ GlobalFlags: *flags, - Product: config.ProReleaseName, - ChartName: config.ProReleaseName, + Product: config.PlatformReleaseName, + ChartName: config.PlatformReleaseName, } startCmd := &cobra.Command{ Use: "start", diff --git a/cmd/pro/start_docker.go b/cmd/pro/start_docker.go index f4851cfb16..285f59ad95 100644 --- a/cmd/pro/start_docker.go +++ b/cmd/pro/start_docker.go @@ -60,7 +60,7 @@ type ContainerDetailsState struct { func (cmd *StartCmd) startDocker(ctx context.Context) error { log.Infof("Starting Devsy Pro in Docker") - name := config.ProReleaseName + name := config.PlatformReleaseName // prepare installation err := cmd.prepareDocker() diff --git a/cmd/pro/start_flags.go b/cmd/pro/start_flags.go index 6c0c2b1750..4207071e34 100644 --- a/cmd/pro/start_flags.go +++ b/cmd/pro/start_flags.go @@ -42,7 +42,7 @@ func (cmd *StartCmd) registerClusterFlags(startCmd *cobra.Command) { cliflags.String( &cmd.Namespace, names.Namespace, - config.ProReleaseName, + config.PlatformReleaseName, "The namespace to install into", ), cliflags.String( diff --git a/cmd/pro/start_uninstall.go b/cmd/pro/start_uninstall.go index 612956357f..c34110d90d 100644 --- a/cmd/pro/start_uninstall.go +++ b/cmd/pro/start_uninstall.go @@ -39,7 +39,7 @@ func uninstall( return err } - if err := cleanupProResources(ctx, kubeClient, restConfig, target.namespace); err != nil { + if err := cleanupPlatformResources(ctx, kubeClient, restConfig, target.namespace); err != nil { return err } @@ -78,7 +78,7 @@ func runHelmUninstall( return nil } -func cleanupProResources( +func cleanupPlatformResources( ctx context.Context, kubeClient kubernetes.Interface, restConfig *rest.Config, @@ -155,7 +155,7 @@ func resolveReleaseName( kubeClient kubernetes.Interface, namespace string, ) (string, error) { - releaseName := config.ProReleaseName + releaseName := config.PlatformReleaseName deploy, err := kubeClient.AppsV1(). Deployments(namespace). Get(ctx, defaultDeploymentName, metav1.GetOptions{}) diff --git a/cmd/pro/workspace/create.go b/cmd/pro/workspace/create.go index 590f859c8e..d7d9bbc16b 100644 --- a/cmd/pro/workspace/create.go +++ b/cmd/pro/workspace/create.go @@ -33,7 +33,7 @@ func NewCreateCmd(globalFlags *flags.GlobalFlags) *cobra.Command { Short: "Create workspace instance", Hidden: true, RunE: func(cobraCmd *cobra.Command, args []string) error { - devsyConfig, provider, err := proutil.FindProProvider( + devsyConfig, provider, err := proutil.FindPlatformProvider( cobraCmd.Context(), cmd.Context, cmd.Provider, diff --git a/cmd/pro/workspace/import.go b/cmd/pro/workspace/import.go index 5c67239293..9f7b28f6f8 100644 --- a/cmd/pro/workspace/import.go +++ b/cmd/pro/workspace/import.go @@ -75,7 +75,7 @@ func (cmd *ImportCmd) Run(ctx context.Context, args []string) error { return fmt.Errorf("usage: devsy pro workspace import ") } - devsyProHost := args[0] + platformHost := args[0] devsyConfig, err := config.LoadConfig(cmd.Context, "") if err != nil { return err @@ -89,7 +89,7 @@ func (cmd *ImportCmd) Run(ctx context.Context, args []string) error { return nil } - ref, err := cmd.findWorkspaceInstance(ctx, devsyConfig, devsyProHost) + ref, err := cmd.findWorkspaceInstance(ctx, devsyConfig, platformHost) if err != nil { return err } @@ -147,9 +147,9 @@ type workspaceInstanceRef struct { func (cmd *ImportCmd) findWorkspaceInstance( ctx context.Context, devsyConfig *config.Config, - devsyProHost string, + platformHost string, ) (workspaceInstanceRef, error) { - provider, err := workspace.ProviderFromHost(ctx, devsyConfig, devsyProHost) + provider, err := workspace.ProviderFromHost(ctx, devsyConfig, platformHost) if err != nil { return workspaceInstanceRef{}, fmt.Errorf("resolve provider: %w", err) } diff --git a/cmd/pro/workspace/list.go b/cmd/pro/workspace/list.go index a982d9d9fd..38a8aca918 100644 --- a/cmd/pro/workspace/list.go +++ b/cmd/pro/workspace/list.go @@ -33,7 +33,7 @@ func NewListCmd(globalFlags *flags.GlobalFlags) *cobra.Command { Short: "List Workspaces", Hidden: true, RunE: func(cobraCmd *cobra.Command, args []string) error { - devsyConfig, providerConfig, err := proutil.FindProProvider( + devsyConfig, providerConfig, err := proutil.FindPlatformProvider( cobraCmd.Context(), cmd.Context, cmd.Provider, diff --git a/cmd/pro/workspace/update.go b/cmd/pro/workspace/update.go index 60bb523c6b..235f37ad3d 100644 --- a/cmd/pro/workspace/update.go +++ b/cmd/pro/workspace/update.go @@ -33,7 +33,7 @@ func NewUpdateCmd(globalFlags *flags.GlobalFlags) *cobra.Command { Short: "Update workspace instance", Hidden: true, RunE: func(cobraCmd *cobra.Command, args []string) error { - devsyConfig, provider, err := proutil.FindProProvider( + devsyConfig, provider, err := proutil.FindPlatformProvider( cobraCmd.Context(), cmd.Context, cmd.Provider, diff --git a/cmd/pro/workspace/watch.go b/cmd/pro/workspace/watch.go index cf6e4ae5d3..41463b58af 100644 --- a/cmd/pro/workspace/watch.go +++ b/cmd/pro/workspace/watch.go @@ -37,7 +37,7 @@ func NewWatchCmd(globalFlags *flags.GlobalFlags) *cobra.Command { Short: "Watch workspaces", Hidden: true, RunE: func(cobraCmd *cobra.Command, args []string) error { - devsyConfig, provider, err := proutil.FindProProvider( + devsyConfig, provider, err := proutil.FindPlatformProvider( cobraCmd.Context(), cmd.Context, cmd.Provider, diff --git a/cmd/root.go b/cmd/root.go index f51c8927d8..d550894296 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -55,10 +55,10 @@ const ( flagLogOutput = "--" + names.LogOutput flagLogFormat = "--" + names.LogFormat - // envProEnabled gates registration of the `pro` command tree. The pro + // envPlatformEnabled gates registration of the `pro` command tree. The pro // feature is not ready for general use; set DEVSY_PRO_ENABLED=true to // expose it (e.g. for internal testing). - envProEnabled = "DEVSY_PRO_ENABLED" + envPlatformEnabled = "DEVSY_PRO_ENABLED" internalCommand = "internal" @@ -78,8 +78,8 @@ const ( $ devsy provider add docker` ) -func proEnabled() bool { - return os.Getenv(envProEnabled) == "true" +func platformEnabled() bool { + return os.Getenv(envPlatformEnabled) == "true" } // isMachineLogFormat reports whether the configured --log-output mode produces @@ -435,7 +435,7 @@ func registerSubcommands(rootCmd *cobra.Command, globalFlags *flags.GlobalFlags) wsCmdPkg.NewWorkspaceCmd(globalFlags), cmdinternal.NewInternalCmd(globalFlags), ) - if proEnabled() { - rootCmd.AddCommand(pro.NewProCmd(globalFlags)) + if platformEnabled() { + rootCmd.AddCommand(pro.NewPlatformCmd(globalFlags)) } } diff --git a/cmd/workspace/troubleshoot.go b/cmd/workspace/troubleshoot.go index 4e35f575a7..71a95854d2 100644 --- a/cmd/workspace/troubleshoot.go +++ b/cmd/workspace/troubleshoot.go @@ -129,7 +129,7 @@ func (cmd *TroubleshootCmd) collectWorkspaceInfo( } if info.Workspace.Platform != nil { - info.WorkspaceTroubleshoot, err = collectWorkspaceProTroubleshoot( + info.WorkspaceTroubleshoot, err = collectWorkspacePlatformTroubleshoot( ctx, info.Config, info.Workspace, info.DevsyProInstances, ) if err != nil { @@ -143,10 +143,10 @@ func (cmd *TroubleshootCmd) collectWorkspaceInfo( } } -// collectWorkspaceProTroubleshoot locates the platform instance that owns the given +// collectWorkspacePlatformTroubleshoot locates the platform instance that owns the given // workspace and retrieves its troubleshooting info. It returns (nil, nil) when // no matching platform instance is configured. -func collectWorkspaceProTroubleshoot( +func collectWorkspacePlatformTroubleshoot( ctx context.Context, devsyConfig *config.Config, ws *pkgprovider.Workspace, diff --git a/pkg/config/env.go b/pkg/config/env.go index 682c7f7d2c..acb4b9b63e 100644 --- a/pkg/config/env.go +++ b/pkg/config/env.go @@ -39,8 +39,8 @@ const ( // EnvDisableTelemetry disables telemetry collection. EnvDisableTelemetry = "DEVSY_DISABLE_TELEMETRY" - // EnvProRunner is set by the Devsy Pro runner pod to mark runner-side CLI invocations. - EnvProRunner = "DEVSY_PRO_RUNNER" + // EnvPlatformRunner is set by the Devsy Pro runner pod to mark runner-side CLI invocations. + EnvPlatformRunner = "DEVSY_PRO_RUNNER" // EnvTelemetryDistinctID is set by the desktop app on spawned CLI // processes so their events share the desktop's analytics identity. diff --git a/pkg/config/repo.go b/pkg/config/repo.go index 13d9b693d5..2dc49ff7ad 100644 --- a/pkg/config/repo.go +++ b/pkg/config/repo.go @@ -16,8 +16,8 @@ const ( GitHubAPIUserURL = "https://api.github.com/users/" + RepoOwner ProviderPrefix = RepoName + "-provider-" - // ProReleaseName is the Helm release / product name for Devsy Pro. - ProReleaseName = RepoName + "-pro" + // PlatformReleaseName is the Helm release / product name for Devsy Pro. + PlatformReleaseName = RepoName + "-pro" // BinaryName is the CLI binary base name used in downloads and SSH host suffixes. BinaryName = RepoName diff --git a/pkg/platform/client.go b/pkg/platform/client.go index 42e0f60487..11d024ecaa 100644 --- a/pkg/platform/client.go +++ b/pkg/platform/client.go @@ -13,9 +13,9 @@ import ( func InitClientFromHost( ctx context.Context, devsyConfig *config.Config, - devsyProHost string, + platformHost string, ) (client.Client, error) { - provider, err := ProviderFromHost(ctx, devsyConfig, devsyProHost) + provider, err := ProviderFromHost(ctx, devsyConfig, platformHost) if err != nil { return nil, fmt.Errorf("provider from platform instance: %w", err) } @@ -39,14 +39,14 @@ func InitClientFromProvider( func ProviderFromHost( ctx context.Context, devsyConfig *config.Config, - devsyProHost string, + platformHost string, ) (string, error) { platformInstanceConfig, err := provider.LoadPlatformInstanceConfig( devsyConfig.DefaultContext, - devsyProHost, + platformHost, ) if err != nil { - return "", fmt.Errorf("load platform instance %s: %w", devsyProHost, err) + return "", fmt.Errorf("load platform instance %s: %w", platformHost, err) } return platformInstanceConfig.Provider, nil diff --git a/pkg/telemetry/collect.go b/pkg/telemetry/collect.go index 0029a4f961..50d579b135 100644 --- a/pkg/telemetry/collect.go +++ b/pkg/telemetry/collect.go @@ -66,8 +66,8 @@ func BootstrapCLI(cmd *cobra.Command) CLICollector { } isUI := os.Getenv(config.EnvUI) == config.BoolTrue - isProRunner := os.Getenv(config.EnvProRunner) == config.BoolTrue - if !isUI && !isProRunner && isCIEnvironment() { + isPlatformRunner := os.Getenv(config.EnvPlatformRunner) == config.BoolTrue + if !isUI && !isPlatformRunner && isCIEnvironment() { log.Debug("telemetry: disabled in CI environment") return &noopCollector{} } @@ -144,7 +144,7 @@ func (d *cliCollector) RecordCLI(err error) { } eventType := config.BinaryName + "_cli" - if os.Getenv(config.EnvProRunner) == config.BoolTrue { + if os.Getenv(config.EnvPlatformRunner) == config.BoolTrue { eventType = config.BinaryName + "_cli_runner" }