Skip to content

Commit a129d18

Browse files
dfa1claude
andcommitted
build: keep the module build green after rebasing onto main
Main added public writer.encode signatures carrying the generated ProtoScalarValue, which core only qualified-exports; suppress the exports lint on those declarations, as VariantData already does. Javadoc no longer auto-links sibling modules: the links pointed at ${project.url}/<artifact>/apidocs/, which does not exist, and a classpath module (jdbc-driver, demo) linking a named one fails the build. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SwhK4W5cgj7y7s4ZPCif5x
1 parent 8557c13 commit a129d18

5 files changed

Lines changed: 12 additions & 0 deletions

File tree

‎pom.xml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,9 @@
458458
<version>${maven-javadoc-plugin.version}</version>
459459
<configuration>
460460
<excludePackageNames>io.github.dfa1.vortex.core.fbs:io.github.dfa1.vortex.core.proto</excludePackageNames>
461+
<!-- Sibling-module links would point at ${project.url}/<artifact>/apidocs/, which does not
462+
exist, and fail a classpath module (jdbc-driver, demo) that links a named one. -->
463+
<detectOfflineLinks>false</detectOfflineLinks>
461464
<!-- Errors and warnings both fail the build. A dangling [Type#member]
462465
reference means a refactor left the docs pointing at a type that no
463466
longer exists; a warning (missing @param, undocumented default

‎writer/src/main/java/io/github/dfa1/vortex/writer/encode/CascadeStep.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
/// @param statsMin minimum stat scalar, or `null`
2222
/// @param statsMax maximum stat scalar, or `null`
2323
/// @param applicable `false` if this encoding cannot handle the input data
24+
// Generated ProtoScalarValue, qualified-exported by core: see EncodeResult.
25+
@SuppressWarnings("exports")
2426
public record CascadeStep(
2527
EncodeNode partialRoot,
2628
List<EncodedBuffer> ownedBuffers,

‎writer/src/main/java/io/github/dfa1/vortex/writer/encode/EncodeResult.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
/// @param encodedBuffers flat list of data buffers in the order referenced by `rootNode`
1313
/// @param statsMin minimum value for zone-map pruning, or `null`
1414
/// @param statsMax maximum value for zone-map pruning, or `null`
15+
// Stats are the generated ProtoScalarValue, which core only qualified-exports; suppress the exports-leak lint
16+
// rather than publish the whole generated codec (as VariantData does).
17+
@SuppressWarnings("exports")
1518
public record EncodeResult(
1619
EncodeNode rootNode,
1720
List<EncodedBuffer> encodedBuffers,

‎writer/src/main/java/io/github/dfa1/vortex/writer/encode/MinMax.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,7 @@
66
///
77
/// @param min the smallest value
88
/// @param max the largest value
9+
// Generated ProtoScalarValue, qualified-exported by core: see EncodeResult.
10+
@SuppressWarnings("exports")
911
public record MinMax(ProtoScalarValue min, ProtoScalarValue max) {
1012
}

‎writer/src/main/java/io/github/dfa1/vortex/writer/encode/PrimitiveEncodingEncoder.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
import java.util.OptionalLong;
1414

1515
/// Write-only encoder for `vortex.primitive` — raw little-endian primitive arrays.
16+
// The stat helpers return the generated ProtoScalarValue, qualified-exported by core: see EncodeResult.
17+
@SuppressWarnings("exports")
1618
public final class PrimitiveEncodingEncoder implements EncodingEncoder {
1719

1820
/// Creates the encoder.

0 commit comments

Comments
 (0)