[Bug] Unable to open commit log panel for jj

[pksunkara]

Description

With prefered adapter set to jj in a colocated repo, open the commit log panel

Expected behavior

Show the commit log panel

Actual behavior

When hovering over a commit in file history panel after opening DiffviewFileHistory %, pressing L is giving me the following:

No log content available for these changes.

In fact, the same issue is happening when I press L on a file in file panel after doing DiffviewOpen.

Weird part is, in a git repo, pressing L on file in file panel after doing DiffviewOpen is giving the following error:

Changes not committed ...

I made sure to test this on files that already were part of several commits, so it's not a new file.

Steps to reproduce

1. Clone https://github.com/jj-vcs/jj with jj
2. Edit Cargo.toml
3. Run nvim Cargo.toml
4. Run :DiffvieFileHistory % in nvim
5. Select a commit in file history panel and press L

Health check

Output of :checkhealth diffview

==============================================================================
diffview:                                                                 2 ⚠️

Checking plugin dependencies ~
- ✅ OK nvim-web-devicons installed.
- ✅ OK mini.icons installed.

Checking VCS tools ~
- The plugin requires at least one of the supported VCS tools to be valid.
- ✅ OK Jujutsu found.
- ✅ OK Jujutsu is up-to-date. (0.42.0)
- ✅ OK Git found.
- ✅ OK Git is up-to-date. (2.54.0)
- ⚠️ WARNING Configured `hg_cmd` is not executable: 'hg'
- ⚠️ WARNING Configured `p4_cmd` is not executable: 'p4'

Log info

Relevant info from :DiffviewLog

############################
### PUT LOG CONTENT HERE ###
############################

Neovim version

NVIM v0.12.2
Build type: RelWithDebInfo
LuaJIT 2.1.1780076327
Run "nvim -V1 -v" for more info

Operating system and version

Linux 7.0.10-arch1-1 x86_64 GNU/Linux

Minimal config

prefered adapter set to `jj`

[dlyongemallo]

Weird part is, in a git repo, pressing L on file in file panel after doing DiffviewOpen is giving the following error:

Changes not committed ...

I made sure to test this on files that already were part of several commits, so it's not a new file.

There seems to be some misunderstanding here. Why is this weird to you? What you described is exactly what I would expect to happen. L shows the commit log of the range being compared in the view. With a bare :DiffviewOpen, that range has no commits.

With :DiffviewFileHistory it does look like a bug, though.

[pksunkara]

L shows the commit log of the range being compared in the view.

1. I might be confused by the phrase "commit log" panel and was thinking it should show a list of commits for that file. Can you confirm that when this plugin says "commit log panel", it actually means a panel showing a single commit's details?

2. What do you mean by "range being compared" here? DiffviewOpen opens on the current diff, right? What is this keymap supposed to do when used in the files panel?

[dlyongemallo]

was thinking it should show a list of commits for that file

It shows the commit log, which is independent of any file. But since you called the command with an empty range, no change has been committed.

What do you mean by "range being compared" here? DiffviewOpen opens on the current diff, right?

See h :DiffviewOpen. When the [rev] argument is empty, it's comparing the working tree against the index, which by definition has no commits. If you run :DiffviewOpen HEAD~10 for example, pressing L in the files panel shows the commit log for the past 10 commits.

[pksunkara]

Okay that makes sense. I confirm that everything with git is okay.

But both commit log panel and commit details panel when using jj doesn't open. Do you need any help to tell you the commands?

[dlyongemallo]

@pksunkara Does this work?

[pksunkara]

Yup, works in DiffFileHistory %. But you should also probably add --no-graph before -r

[pksunkara]

Pressing L in file panel of :DiffviewOpen @..zzz is not opening though. Maybe it's because it's treating @..zzz as a single ref instead of the range it is.

[pksunkara]

@dlyongemallo Should I create a separate issue for the files panel, or will you open this one? I am just worried we might lose track of it.

[dlyongemallo]

What do you mean by "not opening"? It works for me. Can you give more detailed repro steps?

[pksunkara]

It is working everytime except when doing :DiffviewOpen @..zzz using jj. The zzz here refers to the NULL root commit. I am getting the error "No log content available for these changes.". Maybe that's intentional?

---

Also, how do I open the commit log of containing only the commits that touch the particular file from the file panel?