From b97cf7fdffc7692c3632bf7c76ef988155110a60 Mon Sep 17 00:00:00 2001 From: am-kaiser <63399571+am-kaiser@users.noreply.github.com> Date: Tue, 21 Apr 2026 12:32:30 +0200 Subject: [PATCH 1/5] typo in label --- src/axtreme/plotting/doe.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/axtreme/plotting/doe.py b/src/axtreme/plotting/doe.py index a6bc6b57..4d2251f8 100644 --- a/src/axtreme/plotting/doe.py +++ b/src/axtreme/plotting/doe.py @@ -97,7 +97,7 @@ def plot_qoi_estimates_from_experiment( x, qoi_means - 1.96 * qoi_sems, qoi_means + 1.96 * qoi_sems, - label=f"90% Confidence Bound {name}", + label=f"95% Confidence Bound {name}", alpha=0.3, **kwargs, ) From 346b0494274a135270e6798e07856f08357b5249 Mon Sep 17 00:00:00 2001 From: am-kaiser <63399571+am-kaiser@users.noreply.github.com> Date: Tue, 21 Apr 2026 12:43:17 +0200 Subject: [PATCH 2/5] fixed mypy error --- src/axtreme/eval/qoi_helpers.py | 2 +- src/axtreme/plotting/gp_fit.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/axtreme/eval/qoi_helpers.py b/src/axtreme/eval/qoi_helpers.py index 4a7bdbe6..0e820043 100644 --- a/src/axtreme/eval/qoi_helpers.py +++ b/src/axtreme/eval/qoi_helpers.py @@ -40,7 +40,7 @@ def plot_distribution( for samples_i in samples_list: _ = ax.hist(samples_i, density=True, alpha=0.3, bins=len(samples_i) // 5 + 1) _ = ax.set_xlabel("QOI value") - _ = ax.set_title("QOi estimator distibutions") + _ = ax.set_title("QOI estimator distributions") if brute_force: _ = ax.axvline(brute_force, c="black", label=f"Brute force ({brute_force:.2f})") diff --git a/src/axtreme/plotting/gp_fit.py b/src/axtreme/plotting/gp_fit.py index 9065acea..b80a3711 100644 --- a/src/axtreme/plotting/gp_fit.py +++ b/src/axtreme/plotting/gp_fit.py @@ -43,7 +43,7 @@ def plot_surface_over_2d_search_space( # Extract the parameter names and ranges from the search space assert len(search_space.parameters) == 2, "Only 2D search spaces are supported for now." # noqa: PLR2004 - (x1_name, x1_param), (x2_name, x2_param) = list(search_space.parameters.items()) + (_, x1_param), (_, x2_param) = list(search_space.parameters.items()) if not (isinstance(x1_param, RangeParameter) and isinstance(x2_param, RangeParameter)): msg = f"""Expect search_space.parameters to all be of type RangeParameter. @@ -371,11 +371,11 @@ def plot_1d_model(model: SingleTaskGP, X: torch.Tensor | None = None, ax: None | mean = posterior.mean[:, target_idx] var = posterior.variance[:, target_idx] _ = ax.fill_between(X.flatten(), mean - 1.95 * var**0.5, mean + 1.95 * var**0.5, alpha=0.3, color=c) - _ = ax.plot(X, mean, color=c, label=f"gp target {target_idx}") + _ = ax.plot(X, mean, color=c, label=f"GP target {target_idx}") _ = ax.scatter(train_x.flatten(), train_y, color=c) _ = ax.errorbar(train_x.flatten(), train_y, 1.95 * train_var**0.5, fmt="o", color=c) - _ = ax.set_title("Gp prediction") + _ = ax.set_title("GP prediction") return ax From 5bb10431a8ee9c3b94228faee1bf1360db92f7c9 Mon Sep 17 00:00:00 2001 From: Amandine Kaiser <63399571+am-kaiser@users.noreply.github.com> Date: Tue, 21 Apr 2026 13:09:17 +0200 Subject: [PATCH 3/5] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/axtreme/plotting/gp_fit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/axtreme/plotting/gp_fit.py b/src/axtreme/plotting/gp_fit.py index b80a3711..a91f2d18 100644 --- a/src/axtreme/plotting/gp_fit.py +++ b/src/axtreme/plotting/gp_fit.py @@ -40,7 +40,7 @@ def plot_surface_over_2d_search_space( colors: A list of colors to use for each function. If None, will use default Plotly colors. num_points: The number of points in each dimension to evaluate the functions at. """ - # Extract the parameter names and ranges from the search space + # Extract the two parameters from the search space; only their ranges are used below. assert len(search_space.parameters) == 2, "Only 2D search spaces are supported for now." # noqa: PLR2004 (_, x1_param), (_, x2_param) = list(search_space.parameters.items()) From 03fe74d306f4cf6c82fe5a66c5a15b44f2734e77 Mon Sep 17 00:00:00 2001 From: Amandine Kaiser <63399571+am-kaiser@users.noreply.github.com> Date: Tue, 21 Apr 2026 13:27:12 +0200 Subject: [PATCH 4/5] Make pytest output verbose with -vv flag Updated pytest command to include verbose output. --- .github/workflows/_test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index 5115ac23..0d21afad 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -31,4 +31,4 @@ jobs: - name: Run pytest run: > uv run --with pytest --with pytest-cov - pytest --cov -m "not system" + pytest -vv --cov -m "not system" From 2c34b3228831d72f20713fcd4cc28039743c2c08 Mon Sep 17 00:00:00 2001 From: Amandine Kaiser <63399571+am-kaiser@users.noreply.github.com> Date: Tue, 21 Apr 2026 13:38:22 +0200 Subject: [PATCH 5/5] Modify test workflow to include dev dependencies Updated installation step to include development dependencies for testing and simplified pytest command. --- .github/workflows/_test.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index 0d21afad..5724caa0 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -26,9 +26,7 @@ jobs: uses: actions/setup-python@v5 with: python-version: ${{ matrix.python.version }} - - name: Install the project - run: uv sync -p ${{ matrix.python.version }} -U --no-dev + - name: Install the project (include dev deps for tests) + run: uv sync -p ${{ matrix.python.version }} -U - name: Run pytest - run: > - uv run --with pytest --with pytest-cov - pytest -vv --cov -m "not system" + run: uv run pytest -vv --cov -m "not system"