docs: fix Container proxy table to show nested properties correctly - #26268
Open
dave123981 wants to merge 1 commit into
Open
dave123981 wants to merge 1 commit into
dave123981 wants to merge 1 commit into
Conversation
- Restructure Container proxy documentation to clarify that pac and embeddedPac are nested properties within containersProxy object - Add separate table documenting all containersProxy nested properties (locked, mode, http, https, exclude, pac, embeddedPac, transparentPorts) - Include JSON configuration example showing correct structure - Align with settings-reference.md documentation Fixes docker#26263 - Administrators can now clearly see the correct JSON structure to avoid configuration errors
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
area/desktop
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes issue #26263 by restructuring the Container proxy documentation to accurately represent the JSON configuration structure.
Problem
The "Container proxy" section table in
configure-json-file.mdwas misleadingly presentingpacandembeddedPacas if they were separate top-level parameters, when they are actually nested properties within thecontainersProxyobject. This could lead administrators to incorrectly create JSON configurations with invalid structure, causing Docker Desktop to ignore or reject the settings.Solution
pacandembeddedPacas separate parameterscontainersProxyobject:locked- Controls whether users can modify this settingmode- Proxy mode (manualorsystem)http- HTTP proxy URLhttps- HTTPS proxy URLexclude- List of addresses to bypass proxypac- PAC file URLembeddedPac- Embedded PAC script (takes precedence over HTTP/HTTPS)transparentPorts- Ports to use transparent proxysettings-reference.mdfor consistencyRelated issues or tickets
Closes #26263 - [docs-scanner] Container proxy table misleadingly presents nested properties as separate parameters