fixes after the code review

Author: annahileta

src/main/java/com/docusign/DSConfiguration.java

@@ -35,9 +35,9 @@ public class DSConfiguration {
 
     public Boolean isConsentRedirectActivated = false;
 
-    private boolean additionalRedirect = false;
+    private boolean additionalRedirect;
 
-    private boolean shareAccessExampleScenario = false;
+    private boolean shareAccessExampleScenario;
 
     private String principalUserId;
 

src/main/java/com/docusign/EG001ControllerEmbeddedSigning.java

@@ -37,14 +37,10 @@ public class EG001ControllerEmbeddedSigning extends AbstractEsignatureController
     private static final int ANCHOR_OFFSET_Y = 20;
     private static final int ANCHOR_OFFSET_X = 10;
     private static final String SIGNER_CLIENT_ID = "1000";
-    private final Session session;
-    private final User user;
 
     @Autowired
     public EG001ControllerEmbeddedSigning(DSConfiguration config, Session session, User user){
-        super(config, Boolean.valueOf(config.getQuickACG()) ? "quickEmbeddedSigning" : "eg001");
-        this.session = session;
-        this.user = user;
+        super(config, Boolean.valueOf(config.getQuickACG()) ? "quickEmbeddedSigning" : "eg001", session, user);
     }
 
     @Override

src/main/java/com/docusign/controller/eSignature/examples/AbstractEsignatureController.java

@@ -2,6 +2,8 @@
 
 import com.docusign.DSConfiguration;
 import com.docusign.core.controller.AbstractController;
+import com.docusign.core.model.Session;
+import com.docusign.core.model.User;
 import com.docusign.esign.api.AccountsApi;
 import com.docusign.esign.api.EnvelopesApi;
 import com.docusign.esign.api.TemplatesApi;
@@ -21,10 +23,14 @@ public abstract class AbstractEsignatureController extends AbstractController {
 
     protected static final String MODEL_ENVELOPE_OK = "envelopeOk";
     protected static final String MODEL_TEMPLATE_OK = "templateOk";
+    protected final Session session;
+    protected final User user;
     private static final String EXAMPLE_PAGES_PATH = "pages/esignature/examples/";
 
-    public AbstractEsignatureController(DSConfiguration config, String exampleName) {
+    public AbstractEsignatureController(DSConfiguration config, String exampleName, Session session, User user) {
         super(config, exampleName);
+        this.session = session;
+        this.user = user;
     }
 
     protected String getExamplePagesPath() {
@@ -49,7 +55,7 @@ protected ApiClient createApiClient(String basePath, String userAccessToken) {
      * @param userAccessToken user's access token
      * @return an instance of the {@link OAuth.UserInfo}
      */
-    protected OAuth.UserInfo getCurrentUserId(String basePath, String userAccessToken) throws ApiException {
+    protected OAuth.UserInfo getCurrentUserInfo(String basePath, String userAccessToken) throws ApiException {
         ApiClient apiClient = createApiClient(basePath, userAccessToken);
         return apiClient.getUserInfo(userAccessToken);
     }

src/main/java/com/docusign/controller/eSignature/examples/EG002ControllerSigningViaEmail.java

@@ -28,14 +28,9 @@
 @RequestMapping("/eg002")
 public class EG002ControllerSigningViaEmail extends AbstractEsignatureController {
 
-    private final Session session;
-    private final User user;
-
     @Autowired
     public EG002ControllerSigningViaEmail(DSConfiguration config, Session session, User user) {
-        super(config, "eg002");
-        this.session = session;
-        this.user = user;
+        super(config, "eg002", session, user);
     }
 
     @Override

src/main/java/com/docusign/controller/eSignature/examples/EG003ControllerListEnvelopes.java

@@ -26,14 +26,9 @@
 @RequestMapping("/eg003")
 public class EG003ControllerListEnvelopes extends AbstractEsignatureController {
 
-    private final Session session;
-    private final User user;
-
     @Autowired
     public EG003ControllerListEnvelopes(DSConfiguration config, Session session, User user) {
-        super(config, "eg003");
-        this.session = session;
-        this.user = user;
+        super(config, "eg003", session, user);
     }
 
     @Override

src/main/java/com/docusign/controller/eSignature/examples/EG004ControllerEnvelopeInfo.java

@@ -30,14 +30,9 @@
 @RequestMapping("/eg004")
 public class EG004ControllerEnvelopeInfo extends AbstractEsignatureController {
 
-    private final Session session;
-    private final User user;
-
     @Autowired
     public EG004ControllerEnvelopeInfo(DSConfiguration config, Session session, User user) {
-        super(config, "eg004");
-        this.session = session;
-        this.user = user;
+        super(config, "eg004", session, user);
     }
 
     @Override

src/main/java/com/docusign/controller/eSignature/examples/EG005ControllerEnvelopeRecipients.java

@@ -26,14 +26,9 @@
 @RequestMapping("/eg005")
 public class EG005ControllerEnvelopeRecipients extends AbstractEsignatureController {
 
-    private final Session session;
-    private final User user;
-
     @Autowired
     public EG005ControllerEnvelopeRecipients(DSConfiguration config, Session session, User user) {
-        super(config, "eg005");
-        this.session = session;
-        this.user = user;
+        super(config, "eg005", session, user);
     }
 
     @Override

src/main/java/com/docusign/controller/eSignature/examples/EG006ControllerEnvelopeDocs.java

@@ -34,14 +34,9 @@
 @RequestMapping("/eg006")
 public class EG006ControllerEnvelopeDocs extends AbstractEsignatureController {
 
-    private final Session session;
-    private final User user;
-
     @Autowired
     public EG006ControllerEnvelopeDocs(DSConfiguration config, Session session, User user) {
-        super(config, "eg006");
-        this.session = session;
-        this.user = user;
+        super(config, "eg006", session, user);
     }
 
     @Override

src/main/java/com/docusign/controller/eSignature/examples/EG007ControllerEnvelopeGetDoc.java

@@ -36,14 +36,10 @@ public class EG007ControllerEnvelopeGetDoc extends AbstractEsignatureController
     private static final String MODEL_DOCUMENT_OPTIONS = "documentOptions";
     private static final String HTTP_CONTENT_DISPOSITION_VALUE = "inline;filename=";
     private static final String ZIP_EXTENSION = "zip";
-    private final Session session;
-    private final User user;
 
     @Autowired
     public EG007ControllerEnvelopeGetDoc(DSConfiguration config, Session session, User user) {
-        super(config, "eg007");
-        this.session = session;
-        this.user = user;
+        super(config, "eg007", session, user);
     }
 
     @Override

src/main/java/com/docusign/controller/eSignature/examples/EG008ControllerCreateTemplate.java

@@ -30,15 +30,11 @@
 @RequestMapping("/eg008")
 public class EG008ControllerCreateTemplate extends AbstractEsignatureController {
 
-    private final Session session;
-    private final User user;
     private static final String TEMPLATE_NAME = "Example Signer and CC template";
 
     @Autowired
     public EG008ControllerCreateTemplate(DSConfiguration config, Session session, User user) {
-        super(config, "eg008");
-        this.session = session;
-        this.user = user;
+        super(config, "eg008", session, user);
     }
 
     @Override