Skip to content

Commit 8a033f0

Browse files
committed
TransformationFailedException is thrown in EntitiesToIdsTransformer and EntitiesToJsonTransformer when max results is exceeded
1 parent fb4cc71 commit 8a033f0

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

Form/DataTransformer/Entity/EntitiesToIdsTransformer.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,11 @@ public function reverseTransform($values)
8585
return $collection;
8686
}
8787
$values = \array_unique($values);
88+
if (count($values) > $this->maxResults) {
89+
throw new TransformationFailedException(
90+
sprintf('This collection should contain %s elements or less.', $this->maxResults)
91+
);
92+
}
8893

8994
try {
9095
$hash = $this->getCacheHash($values);
@@ -93,7 +98,6 @@ public function reverseTransform($values)
9398
} else {
9499
//Result not in cache
95100

96-
$this->queryBuilder->setMaxResults($this->maxResults);
97101
$queryBuilderLoader = new ORMQueryBuilderLoader($this->queryBuilder);
98102

99103
foreach ($queryBuilderLoader->getEntitiesByIds($this->identifier, $values) as $entity) {

Form/DataTransformer/Entity/EntitiesToJsonTransformer.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,11 @@ public function reverseTransform($value)
130130
if (count($ids) == 0) {
131131
return $collection;
132132
}
133+
if (count($ids) > $this->maxResults) {
134+
throw new TransformationFailedException(
135+
sprintf('This collection should contain %s elements or less.', $this->maxResults)
136+
);
137+
}
133138

134139
try {
135140
$hash = $this->getCacheHash($ids);
@@ -138,7 +143,6 @@ public function reverseTransform($value)
138143
} else {
139144
//Result not in cache
140145

141-
$this->queryBuilder->setMaxResults($this->maxResults);
142146
$queryBuilderLoader = new ORMQueryBuilderLoader($this->queryBuilder);
143147

144148
foreach ($queryBuilderLoader->getEntitiesByIds($this->identifier, $ids) as $entity) {

0 commit comments

Comments
 (0)