From ebc7b7e21953904b43f3b782078c7c7f35c8954c Mon Sep 17 00:00:00 2001 From: Daniel Ecer Date: Mon, 17 Aug 2026 12:30:22 +0100 Subject: [PATCH] Drop the shipped-config assertion about grobid_custom_hybrid It asserted that grobid_custom_hybrid resolves to exactly what grobid_crf resolves to, which describes the config rather than any behaviour: the first custom model the profile takes on makes it fail, so a config change would have to arrive with a test change. What it was there to show - that extends inherits the base and lets a profile state only its differences - is already covered by profile_b_extended in MINIMAL_PROFILE_CONFIG, and by the seven cases in TestResolveSequenceModelProfile, none of which a model swap disturbs. --- tests/config/config_test.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/tests/config/config_test.py b/tests/config/config_test.py index 0ffa6c12..6f1f41f3 100644 --- a/tests/config/config_test.py +++ b/tests/config/config_test.py @@ -10,7 +10,6 @@ _deep_merge, _resolve_sequence_model_profile ) -from sciencebeam_parser.resources.default_config import DEFAULT_CONFIG_FILE MINIMAL_PROFILE_CONFIG = { @@ -293,12 +292,3 @@ def test_should_override_bool_value_with_env_var( config = AppConfig.load_yaml(str(config_path)) config = config.apply_environment_variables() assert config.props['key1'] is False - - -class TestDefaultConfigProfiles: - def _resolve_models(self, profile_name: str) -> dict: - config = AppConfig.load_yaml(DEFAULT_CONFIG_FILE) - return config.resolve_profile(profile_name)['models'] - - def test_grobid_custom_hybrid_inherits_every_grobid_crf_model(self): - assert self._resolve_models('grobid_custom_hybrid') == self._resolve_models('grobid_crf')