Repository navigation
chore: depend on the workspace @effect-app/cli - #913
Merged
Merged
Conversation
The root devDependency was still the published 2.1.0-beta.35 tarball, which did not match the workspace package. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
Node 24 strips types, so the workspace entry loads packages/cli/src and the root build no longer compiles the CLI before the other packages. The published manifest still points at dist JavaScript, because Node will not run TypeScript inside node_modules. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point the root devDependency
@effect-app/cliat the workspace package (workspace:*) instead of the published2.1.0-beta.35tarball.That package now runs from TypeScript source. Node 24 strips types by default, the workspace bin loads
packages/cli/src/index.ts, and the package exports point atsrc/*.ts, sopnpm effaworks before any build. The rootbuildscript no longer compiles the CLI before the other packages.tsconfig.all.jsonstill includes the CLI, sopnpm buildemitsdistfor publish and rewrites declaration imports to.js.The published manifest keeps
bin,exports, andtypesVersionsondistJavaScript. Node will not run TypeScript files whose real path is insidenode_modules, so the npm package stays compiled. The repo requires Node>=24, which matches CI.Test plan
packages/cli/distremoved,node packages/cli/bin.js --helpand theeffashim print helpimport '@effect-app/cli/argv-patch'loads the source export through the workspace linktsgo --buildinpackages/cliemitsdist/index.jswith a shebang and.jsrelative importsbin,exports, andtypesVersionsatdist, andnode packages/cli/dist/index.js --versionrunspnpm --dir packages/cli test:runpassesNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.