Git clone success dialog should be a toast

[danirabbit]

What Happened?

When a git repository is successfully cloned it shows a whole dialog box stating that the clone was successful

Steps to Reproduce

1. Clone a git repository
2. See a dialog box when it succeeds

Expected Behavior

This should be a Granite.Toast instead if the window is focused or a system notification if the window is not focused.

Toasts are less intrusive and more appropriate than a dialog when an additional decision doesn't need to be made, and notifications are more helpful for long-running tasks where I might have navigated to another workspace while I'm waiting for the task to be completed.

OS Version

8.x (Circe)

OS Architecture

amd64 (on most hardwares)

Session Type

Secure Session (Wayland)

Software Version

Latest release (I have run all updates)

Log Output

Hardware Info

No response

[jeremypw]

An alternative would be to show a progress window like Files - see #1608 for proof of principle. Agreed that the current situation is overkill, but I think there should be some indication that something is happening. Cloning a large repo can take a significant amount of time.

[zeebok]

Would it be possible to set it up so when it begins cloning, it creates the project in the tree view panel, and that project entry has a progress meter? One can see the info without the window in your face, plus still having a toast or notification when it finishes will be nice

[jeremypw]

@zeebok Its a nice idea and less obtrusive, although putting a progress meter in a sidebar entry would require new infrastructure.

[zeebok]

At the very least I would expect this to make use of the progress bar in the dock!