Skip to content
This repository was archived by the owner on Nov 11, 2017. It is now read-only.
This repository was archived by the owner on Nov 11, 2017. It is now read-only.

everyProperty is deprecated... #4

@jodarove

Description

@jodarove

On todos_controller.js, specifically in the allAreDone computed property there is:

return !!this.get('length') && this.everyProperty('isCompleted', true);

i think it may be:

return this.get('length') && this.everyBy('isCompleted', true);

Note that i also removed the double "!!"

i think also should be changed in the starting guide from emberjs.com (http://emberjs.com/guides/getting-started/show-when-all-todos-are-complete/ and http://emberjs.com/guides/getting-started/toggle-all-todos/) .

--- js/controllers/todos_controller.js  (revision 81801d87da42d0c83685ff946c46de68589ce38f)
+++ js/controllers/todos_controller.js  (revision )
@@ -43,7 +43,7 @@

   allAreDone: function (key, value) {
     if (value === undefined) {
-      return !!this.get('length') && this.everyProperty('isCompleted', true);
+      return this.get('length') && this.everyBy('isCompleted', true);
     } else {
       this.setEach('isCompleted', value);
       this.invoke('save')

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions