feat(rg): support pcre2 patterns#1719
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 290a388 | Commit Preview URL | May 23 2026, 06:31 PM |
4 tasks
chaliy
added a commit
that referenced
this pull request
May 24, 2026
## What Replace Python CI usage of `PyO3/maturin-action@v1` with explicit `python -m pip install "maturin>=1.4,<2.0"` plus `python -m maturin build` commands. ## Why Main went red after the #1719 merge because Python CI hit infrastructure/action failures: one checkout auth failure and one `PyO3/maturin-action@v1` JavaScript error, `TypeError: candidates is not iterable`, in the Python 3.13 build path. Rerunning restored main, but the workflow should avoid the brittle action path. ## How Keep the existing Rust/setup/cache flow, install maturin directly under the selected Python interpreter, and invoke the same build arguments from shell in test, examples, and build-wheel jobs. ## Risk - Low - This keeps the same maturin version range already declared by the project and preserves the existing wheel build commands. ## Checklist - [x] YAML parses locally - [x] `git diff --check` passed - [x] `just pre-pr` passed locally - [x] Main Python workflow rerun is green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add PCRE2-compatible matching for rg via the existing
fancy-regexengine.-P,--pcre2,--engine=pcre2, and--auto-hybrid-regexnow route search matching through the PCRE2-compatible matcher instead of being parse-only no-ops.Why
Real ripgrep supports look-around and backreferences under PCRE2. Bashkit rg previously accepted these flags but still used Rust regex, so PCRE2-only patterns failed or diverged from real rg.
How
Introduce an
RgMatcherabstraction over Rust regex andfancy-regex, update output/color/replacement paths to use it, update help text, and add real-rg differential cases for lookahead, lookbehind with-o, and backreferences.Risk
Checklist
cargo fmt && just pre-prpassed locally