Skip to content

Commit bd14d81

Browse files
committed
fix lint error
1 parent 02f5f74 commit bd14d81

2 files changed

Lines changed: 22 additions & 8 deletions

File tree

firebase_admin/app_check.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ def verify_token(self, token: str, consume: bool = False) -> Dict[str, Any]:
107107
except requests.exceptions.RequestException as error:
108108
raise _utils.handle_requests_error(error)
109109

110-
already_consumed = body.get('alreadyConsumed', False) if isinstance(body, dict) else False
110+
already_consumed = False
111+
if isinstance(body, dict):
112+
already_consumed = body.get('alreadyConsumed', False)
111113
verified_claims['already_consumed'] = bool(already_consumed)
112114

113115
return verified_claims

tests/test_app_check.py

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"""Test cases for the firebase_admin.app_check module."""
1616
import base64
1717
import pytest
18+
import requests
1819

1920
from jwt import PyJWK, InvalidAudienceError, InvalidIssuerError
2021
from jwt import ExpiredSignatureError, InvalidSignatureError
@@ -280,36 +281,47 @@ def test_verify_token_with_consume_true_not_consumed(self, mocker):
280281
mocker.patch("jwt.get_unverified_header", return_value=JWT_PAYLOAD_SAMPLE.get("headers"))
281282
app = firebase_admin.get_app()
282283
app_check_service = app_check._get_app_check_service(app)
283-
mock_body = mocker.patch.object(app_check_service._http_client, "body", return_value={"alreadyConsumed": False})
284+
mock_body = mocker.patch.object(
285+
app_check_service._http_client, "body", return_value={"alreadyConsumed": False}
286+
)
284287

285288
payload = app_check.verify_token("encoded", app=app, consume=True)
286289
expected = JWT_PAYLOAD_SAMPLE.copy()
287290
expected["app_id"] = APP_ID
288291
expected["already_consumed"] = False
289292
assert payload == expected
290293

291-
expected_url = f"https://firebaseappcheck.googleapis.com/v1/projects/{PROJECT_ID}:verifyAppCheckToken"
292-
mock_body.assert_called_once_with("post", expected_url, json={"app_check_token": "encoded"})
294+
expected_url = (
295+
f"https://firebaseappcheck.googleapis.com/v1/projects/{PROJECT_ID}:verifyAppCheckToken"
296+
)
297+
mock_body.assert_called_once_with(
298+
"post", expected_url, json={"app_check_token": "encoded"}
299+
)
293300

294301
def test_verify_token_with_consume_true_already_consumed(self, mocker):
295302
mocker.patch("jwt.decode", return_value=JWT_PAYLOAD_SAMPLE)
296303
mocker.patch("jwt.PyJWKClient.get_signing_key_from_jwt", return_value=PyJWK(signing_key))
297304
mocker.patch("jwt.get_unverified_header", return_value=JWT_PAYLOAD_SAMPLE.get("headers"))
298305
app = firebase_admin.get_app()
299306
app_check_service = app_check._get_app_check_service(app)
300-
mock_body = mocker.patch.object(app_check_service._http_client, "body", return_value={"alreadyConsumed": True})
307+
mock_body = mocker.patch.object(
308+
app_check_service._http_client, "body", return_value={"alreadyConsumed": True}
309+
)
301310

302311
payload = app_check.verify_token("encoded", app=app, consume=True)
303312
expected = JWT_PAYLOAD_SAMPLE.copy()
304313
expected["app_id"] = APP_ID
305314
expected["already_consumed"] = True
306315
assert payload == expected
307316

308-
expected_url = f"https://firebaseappcheck.googleapis.com/v1/projects/{PROJECT_ID}:verifyAppCheckToken"
309-
mock_body.assert_called_once_with("post", expected_url, json={"app_check_token": "encoded"})
317+
expected_url = (
318+
f"https://firebaseappcheck.googleapis.com/v1/projects/{PROJECT_ID}:verifyAppCheckToken"
319+
)
320+
mock_body.assert_called_once_with(
321+
"post", expected_url, json={"app_check_token": "encoded"}
322+
)
310323

311324
def test_verify_token_with_consume_true_backend_error(self, mocker):
312-
import requests
313325
mocker.patch("jwt.decode", return_value=JWT_PAYLOAD_SAMPLE)
314326
mocker.patch("jwt.PyJWKClient.get_signing_key_from_jwt", return_value=PyJWK(signing_key))
315327
mocker.patch("jwt.get_unverified_header", return_value=JWT_PAYLOAD_SAMPLE.get("headers"))

0 commit comments

Comments
 (0)