From 05406a1056d4541c7e0a0fd52f6f9fe94057b2f2 Mon Sep 17 00:00:00 2001 From: Adrian Czerwiec Date: Thu, 13 Aug 2026 12:03:47 +0200 Subject: [PATCH 1/2] use active instead of unspecified --- fishjam/server_notifications.proto | 3 +-- fishjam_protos/lib/fishjam/server_notifications.pb.ex | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fishjam/server_notifications.proto b/fishjam/server_notifications.proto index b32f91f..36ae4b6 100644 --- a/fishjam/server_notifications.proto +++ b/fishjam/server_notifications.proto @@ -233,10 +233,9 @@ message ServerMessage { string streamer_id = 2; } - // Notification sent when a recording changes status message RecordingStatusChanged { enum Status { - STATUS_UNSPECIFIED = 0; + STATUS_ACTIVE = 0; STATUS_FINISHED = 1; STATUS_AVAILABLE = 2; STATUS_FAILED = 3; diff --git a/fishjam_protos/lib/fishjam/server_notifications.pb.ex b/fishjam_protos/lib/fishjam/server_notifications.pb.ex index 938a990..1e54a62 100644 --- a/fishjam_protos/lib/fishjam/server_notifications.pb.ex +++ b/fishjam_protos/lib/fishjam/server_notifications.pb.ex @@ -49,7 +49,7 @@ defmodule Fishjam.ServerMessage.RecordingStatusChanged.Status do protoc_gen_elixir_version: "0.17.0", syntax: :proto3 - field :STATUS_UNSPECIFIED, 0 + field :STATUS_ACTIVE, 0 field :STATUS_FINISHED, 1 field :STATUS_AVAILABLE, 2 field :STATUS_FAILED, 3 From 95abb2c8d1b68a90849b4156fe43d11a2bf4d368 Mon Sep 17 00:00:00 2001 From: Adrian Czerwiec Date: Thu, 13 Aug 2026 12:12:12 +0200 Subject: [PATCH 2/2] lint and doc --- buf.yaml | 2 ++ doc/docs.md | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/buf.yaml b/buf.yaml index e9779cd..8896b2c 100644 --- a/buf.yaml +++ b/buf.yaml @@ -11,3 +11,5 @@ lint: ignore_only: PACKAGE_VERSION_SUFFIX: - fishjam + ENUM_ZERO_VALUE_SUFFIX: + - fishjam/server_notifications.proto diff --git a/doc/docs.md b/doc/docs.md index ff2adc6..9474234 100644 --- a/doc/docs.md +++ b/doc/docs.md @@ -1635,7 +1635,7 @@ Notification sent when peer updates its metadata ### ServerMessage.RecordingStatusChanged -Notification sent when a recording changes status + | Field | Type | Label | Description | @@ -1963,7 +1963,7 @@ Defines message groups for which peer can subscribe | Name | Number | Description | | ---- | ------ | ----------- | -| STATUS_UNSPECIFIED | 0 | | +| STATUS_ACTIVE | 0 | | | STATUS_FINISHED | 1 | | | STATUS_AVAILABLE | 2 | | | STATUS_FAILED | 3 | |