fix(version): satisfy errcheck + make broker_egress test platform-correct

- check fmt.Fprintln/Fprintf returns (errcheck under golangci-lint v2.11)
- assert broker_egress matches the compile-time capability (true on unix, false
  on windows) instead of hard-asserting true, which failed the windows build

Author: ysyneu

internal/cli/version.go

@@ -24,6 +24,7 @@ func newVersionCmd() *cobra.Command {
 		Use:   "version",
 		Short: "Print version information",
 		Run: func(cmd *cobra.Command, args []string) {
+			out := cmd.OutOrStdout()
 			// A structured (--json / --output-format) request emits a
 			// machine-readable object that includes broker_egress, the capability
 			// the runner probes before advertising broker mode to safari. An older
@@ -38,13 +39,13 @@ func newVersionCmd() *cobra.Command {
 					"broker_egress": brokerEgressCapable,
 				})
 				if err != nil {
-					fmt.Fprintln(cmd.ErrOrStderr(), err)
+					_, _ = fmt.Fprintln(cmd.ErrOrStderr(), err)
 					return
 				}
-				fmt.Fprintln(cmd.OutOrStdout(), string(b))
+				_, _ = fmt.Fprintln(out, string(b))
 				return
 			}
-			fmt.Fprintf(cmd.OutOrStdout(), "flashduty version %s (%s) built %s\n", versionStr, commitStr, dateStr)
+			_, _ = fmt.Fprintf(out, "flashduty version %s (%s) built %s\n", versionStr, commitStr, dateStr)
 		},
 	}
 }

internal/cli/version_test.go

@@ -20,9 +20,10 @@ func TestVersionPlainOutput(t *testing.T) {
 }
 
 // TestVersionJSONAdvertisesBrokerEgress locks the capability contract the runner
-// depends on: `fduty version --json` must emit a broker_egress field that is true
-// on this (unix) build. If this regresses, broker-capable runners would stop
-// advertising broker mode and silently fall back to the legacy env-key path.
+// depends on: `fduty version --json` must emit a broker_egress field whose value
+// matches this build's compile-time capability (true on unix, false elsewhere).
+// If the field went missing, broker-capable runners would stop advertising
+// broker mode and silently fall back to the legacy env-key path.
 func TestVersionJSONAdvertisesBrokerEgress(t *testing.T) {
 	origJSON := flagJSON
 	flagJSON = true
@@ -33,14 +34,15 @@ func TestVersionJSONAdvertisesBrokerEgress(t *testing.T) {
 	cmd.SetOut(&buf)
 	cmd.Run(cmd, nil)
 
-	var got struct {
-		Version      string `json:"version"`
-		BrokerEgress bool   `json:"broker_egress"`
-	}
+	var got map[string]any
 	if err := json.Unmarshal(buf.Bytes(), &got); err != nil {
 		t.Fatalf("version --json must be valid JSON, got %q: %v", buf.String(), err)
 	}
-	if !got.BrokerEgress {
-		t.Fatalf("broker_egress must be true on a unix build, got: %q", buf.String())
+	v, ok := got["broker_egress"]
+	if !ok {
+		t.Fatalf("version --json must include the broker_egress field, got: %q", buf.String())
+	}
+	if v != brokerEgressCapable {
+		t.Fatalf("broker_egress = %v, want %v (compile-time capability)", v, brokerEgressCapable)
 	}
 }