Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Improve Field Picker Search Performance #535

Description

@daedalus28

https://github.com/smartprocure/contexture-react/blob/53127ed0058ab4028593f2c81177ce66c39c8d49/src/greyVest/NestedPicker.js#L144

Can be changed to

let matchLabel = str => {
  let match = F.matchAllWords(str)
  return _.filter(x => match(x.label))
}

This will avoid recreating the regex on every iteration. Not sure if this is the bottleneck, but it's an easy performance win.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions