Open Pan Docs links in target=_blank by default

[avivace]

There are various Pan Docs links spread around the tutorial. They should open in a new tab by default so that they stay as "companions" and don't break the attention on the main document

See rust-lang/mdBook#2453

[kg4zow]

Rather than this being a per-book "global" option, I think it would make sense for this to be a per-link option. Not every link in a book would need to be opened in a new tab/window.

See this comment for more details.

[avivace]

Rather than this being a per-book "global" option, I think it would make sense for this to be a per-link option. Not every link in a book would need to be opened in a new tab/window.

See this comment for more details.

This issue is specifically about 'Pan Docs' links, not links in general - Pan Docs is sort-of a manual for which you know you'd want on the side (and not close the tutorial page calling it)

[kg4zow]

Sure, but not every link in a book would need to open in a new tab/window. Links that point to other pages in the same book should open in the same tab, and links that point to external sites (not in the same book) ... you might want to open them in a new tab/window, and you might want to open them in the same tab.

My point is, this should be a "per link" choice, rather than a "per book" choice that affects every link in the book. My apologies if that wasn't clear in my comment above.

[avivace]

Sure, but not every link in a book would need to open in a new tab/window. Links that point to other pages in the same book should open in the same tab, and links that point to external sites (not in the same book) ... you might want to open them in a new tab/window, and you might want to open them in the same tab.

My point is, this should be a "per link" choice, rather than a "per book" choice that affects every link in the book. My apologies if that wasn't clear in my comment above.

This issue is about links going from the tutorial to the 'companion' Pan Docs. I've changed the issue title to reflect that

[Les-Wet]

This is an easy fix that I can knock out pretty quickly with a script to find all the pandocs links then reformatting them to make sure they open in a new tab.

However, if I am understanding the issue @avivace referenced (rust-lang/mdBook#2453), doing this in markdown isn't supported yet for mdbook. At least my testing of the syntax shown here doesn't work in mdbook, whereas it works with inline HTML as the author of the mdbook issue points out.

Are we ok with putting inline HTML in the project? If so, I can go ahead and implement that. If not, maybe we need to hop on that issue and notify mdbook that that is a feature we're interested in. Could take time before upstream would make it into gb-asm-tutorial though, especially considering #134.

[avivace]

Yeah I'd like this to be done mdbook-side so that we don't pollute the markdown source with inline-html links

[Les-Wet]

Ok I'll leave this to someone with more experience with Rust and mdbook then.