From 044dc6c9d1b769d42fc96b20c29f6f81d6ef3c95 Mon Sep 17 00:00:00 2001 From: Mark Dumay <61946753+markdumay@users.noreply.github.com> Date: Mon, 13 Jul 2026 05:15:48 +0200 Subject: [PATCH] feat(structures): add missing members consumed by shared partials Adds two additive members to the shared types in data/structures/_types.yml (and its exampleSite shadow copy), reported by the mod-blocks mod-utils v6 adoption (hinode wave3-blocks-report.md, structure-gap section): * testimonials[].icon: mod-blocks assets/testimonial-carousel.html reads $item.icon for every testimonial and forwards it to assets/testimonial.html, but the shared testimonials type only declared logo/content/client/link, triggering "unsupported attribute 'icon'" warnings on Bookshop-validated testimonials content. The global icon argument already exists in _arguments.yml (string | uint64, optional). * video.media-id: hinode's assets/video.html resolves the clip ID via $args.mediaId, falling back to $args.id only when media-id is absent, and mod-blocks video-message.hugo.html builds its video dict from media_id / "media-id". The shared video type only declared id, so any content using media-id validated clean at the shortcode layer but failed the shared-type check. id is kept (no removal) since assets/video.html still falls back to it. The global media-id argument already exists in _arguments.yml (string, optional). pnpm test: golden check passed (13 groups), zero drift. No existing test fixture (data/tests/*.yml, data/structures/test-*.yml) exercises the testimonials or video shared types, so the two additive members do not surface in any generated golden file. Co-Authored-By: Claude Fable 5 --- data/structures/_types.yml | 2 ++ exampleSite/data/structures/_types.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/data/structures/_types.yml b/data/structures/_types.yml index f40574c..cdc9342 100644 --- a/data/structures/_types.yml +++ b/data/structures/_types.yml @@ -94,6 +94,7 @@ types: provider: account: id: + media-id: autoplay: query-args: testimonials: @@ -101,6 +102,7 @@ types: content: client: link: + icon: client: contact: role: diff --git a/exampleSite/data/structures/_types.yml b/exampleSite/data/structures/_types.yml index 9071608..745c648 100644 --- a/exampleSite/data/structures/_types.yml +++ b/exampleSite/data/structures/_types.yml @@ -98,6 +98,7 @@ types: provider: account: id: + media-id: autoplay: query-args: testimonials: @@ -105,6 +106,7 @@ types: content: client: link: + icon: client: contact: role: