From f83d72ac9f3f91fbaf968d5ab8d4a1f7a75a5b5b Mon Sep 17 00:00:00 2001 From: Etienne Lescot Date: Sun, 9 Aug 2026 00:05:19 +0200 Subject: [PATCH] docs(ci): correct the include-hidden-files rationale in docs.yml The comment added in 7c4827b9 claims Docusaurus writes a `.nojekyll` into website/build, and justifies `include-hidden-files: true` as restoring it. That is wrong: Docusaurus only writes `.nojekyll` from its own `deploy` command, not from a plain `build`. The Pages artifact published by that very commit (id 9028339047) was unpacked and contains 59 entries and no dot-entries at all, so the flag is currently a no-op. Keep the flag, fix the reason. Preserving the v3 default matters for what comes later, not for what is there now: a `.well-known/` added for domain verification or security.txt would be dropped from the deploy silently under the v4+ default, and that failure is invisible until someone checks why the verification never completes. Co-Authored-By: Claude Opus 5 --- .github/workflows/docs.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index dbd98b36c..554024276 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -60,11 +60,15 @@ jobs: uses: actions/upload-pages-artifact@fc324d3547104276b827a68afc52ff2a11cc49c9 # v5.0.0 with: path: website/build - # v4 stopped bundling dotfiles, and Docusaurus writes a `.nojekyll` - # into website/build. The artifact-based Pages deploy never runs - # Jekyll, so losing it would probably be harmless — but "probably" is - # not worth finding out on the live site, and this restores exactly - # what v3 uploaded. `.git`/`.github` stay excluded either way. + # v4 stopped bundling dotfiles by default. Nothing in website/build + # is hidden today — the deployed artifact from 7c4827b9 was checked + # and contains no dot-entries at all, so this changes nothing now + # (Docusaurus only writes a `.nojekyll` on its own `deploy` command, + # not in a plain `build`). It is set so that stays true by accident + # rather than by omission: a `.well-known/` for domain verification + # or security.txt is the realistic case, and under the v4+ default it + # would vanish from the deploy silently. `.git` and `.github` are + # excluded regardless of this flag. include-hidden-files: true deploy: