test: Port the audit fixes to Boot 3 no-agent

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: runningcode

sentry-spring-boot-jakarta/src/integrationTestOtelNoAgent/kotlin/io/sentry/spring/boot/jakarta/otelnoagentintegrationtest/DistributedTracingIntegrationTest.kt

@@ -4,6 +4,7 @@ import com.google.common.truth.Truth.assertThat
 import io.sentry.SentryEnvelope
 import io.sentry.protocol.SentryId
 import io.sentry.test.transaction
+import kotlin.random.Random
 import kotlin.test.Test
 import org.springframework.http.HttpEntity
 import org.springframework.http.HttpHeaders
@@ -27,26 +28,26 @@ class DistributedTracingIntegrationTest : IntegrationTest() {
       )
     assertThat(status).isEqualTo(500)
 
-    awaitTransaction("GET /tracing/{id}", traceId)
+    val incoming = awaitTransaction("GET /tracing/{id}", traceId).transaction()!!
+    assertThat(incoming.request?.url).endsWith("/tracing/1")
     awaitTransaction("GET /person/{id}", traceId)
   }
 
   @Test
   fun `unsampled trace sends no transactions`() {
     val traceId = SentryId()
+    // An id only this request uses, because a mishandled header could start a trace of its own.
+    val id = Random.nextLong(2, Long.MAX_VALUE)
     val status =
       get(
-        "/tracing/1",
+        "/tracing/$id",
         sentryTrace = "$traceId-424cffc8f94feeee-0",
         baggage =
           "sentry-public_key=502f25099c204a2fbf4cb16edc5975d1,sentry-sample_rand=0.456789,sentry-sample_rate=0.5,sentry-sampled=false,sentry-trace_id=$traceId,sentry-transaction=HTTP%20GET",
       )
     assertThat(status).isEqualTo(500)
 
-    server.assertNoEnvelope {
-      isTransaction(it, "GET /tracing/{id}", traceId) ||
-        isTransaction(it, "GET /person/{id}", traceId)
-    }
+    server.assertNoEnvelope { isForRequest(it, id) }
   }
 
   @Test
@@ -63,6 +64,8 @@ class DistributedTracingIntegrationTest : IntegrationTest() {
 
     val incoming = awaitTransaction("GET /tracing/{id}", traceId).header.traceContext!!
     val outgoing = awaitTransaction("GET /person/{id}", traceId).header.traceContext!!
+    assertThat(incoming.traceId).isEqualTo(traceId)
+    assertThat(outgoing.traceId).isEqualTo(traceId)
     assertThat(incoming.sampleRand).isNotNull()
     assertThat(outgoing.sampleRand).isEqualTo(incoming.sampleRand)
   }
@@ -81,6 +84,8 @@ class DistributedTracingIntegrationTest : IntegrationTest() {
 
     val incoming = awaitTransaction("GET /tracing/{id}", traceId).header.traceContext!!
     val outgoing = awaitTransaction("GET /person/{id}", traceId).header.traceContext!!
+    assertThat(incoming.traceId).isEqualTo(traceId)
+    assertThat(outgoing.traceId).isEqualTo(traceId)
     assertThat(incoming.sampleRate).isNotEqualTo("0.5")
     assertThat(outgoing.sampleRate).isEqualTo(incoming.sampleRate)
   }
@@ -130,6 +135,12 @@ class DistributedTracingIntegrationTest : IntegrationTest() {
       isTransaction(it, name, traceId)
     }
 
+  /** Whether [envelope] is a transaction for `/tracing/[id]` or the `/person/[id]` it calls. */
+  private fun isForRequest(envelope: SentryEnvelope, id: Long): Boolean {
+    val url = envelope.transaction()?.request?.url ?: return false
+    return url.endsWith("/tracing/$id") || url.endsWith("/person/$id")
+  }
+
   private fun isTransaction(envelope: SentryEnvelope, name: String, traceId: SentryId): Boolean {
     val transaction = envelope.transaction() ?: return false
     return transaction.transaction == name && transaction.contexts.trace?.traceId == traceId

sentry-spring-boot-jakarta/src/integrationTestOtelNoAgent/kotlin/io/sentry/spring/boot/jakarta/otelnoagentintegrationtest/GraphqlIntegrationTest.kt

@@ -68,6 +68,8 @@ class GraphqlIntegrationTest : IntegrationTest() {
     val tasks = response["data"]["tasks"]
     assertThat(tasks.size()).isEqualTo(5)
     assertThat(tasks[0]["id"].asText()).isEqualTo("T1")
+    assertThat(tasks[0]["assigneeId"].asText()).isEqualTo("A3")
+    assertThat(tasks[0]["creatorId"].asText()).isEqualTo("C3")
     assertThat(tasks[0]["assignee"]["id"].asText()).isEqualTo("A3")
     assertThat(tasks[0]["creator"]["id"].asText()).isEqualTo("C3")
 

sentry-spring-boot-jakarta/src/integrationTestOtelNoAgent/kotlin/io/sentry/spring/boot/jakarta/otelnoagentintegrationtest/MetricController.kt

@@ -0,0 +1,33 @@
+package io.sentry.spring.boot.jakarta.otelnoagentintegrationtest
+
+import io.sentry.Sentry
+import io.sentry.metrics.MetricsUnit
+import org.springframework.web.bind.annotation.GetMapping
+import org.springframework.web.bind.annotation.PathVariable
+import org.springframework.web.bind.annotation.RequestMapping
+import org.springframework.web.bind.annotation.RestController
+
+@RestController
+@RequestMapping("/metric/")
+open class MetricController {
+  @GetMapping("count")
+  open fun count(): String {
+    Sentry.setAttribute("user.type", "admin")
+    Sentry.setAttribute("feature.version", 2)
+    Sentry.metrics().count("countMetric")
+    return "count metric increased"
+  }
+
+  @GetMapping("gauge/{value}")
+  open fun gauge(@PathVariable("value") value: Long): String {
+    Sentry.metrics().gauge("memory.free", value.toDouble(), MetricsUnit.Information.BYTE)
+    return "gauge metric tracked"
+  }
+
+  @GetMapping("distribution/{value}")
+  open fun distribution(@PathVariable("value") value: Long): String {
+    Sentry.metrics()
+      .distribution("distributionMetric", value.toDouble(), MetricsUnit.Duration.MILLISECOND)
+    return "distribution metric tracked"
+  }
+}

sentry-spring-boot-jakarta/src/integrationTestOtelNoAgent/kotlin/io/sentry/spring/boot/jakarta/otelnoagentintegrationtest/MetricsIntegrationTest.kt

@@ -0,0 +1,50 @@
+package io.sentry.spring.boot.jakarta.otelnoagentintegrationtest
+
+import com.google.common.truth.Truth.assertThat
+import io.sentry.Sentry
+import io.sentry.SentryMetricsEvents
+import io.sentry.test.hasMetric
+import io.sentry.test.hasMetricWithAttribute
+import io.sentry.test.metrics
+import kotlin.test.Test
+
+class MetricsIntegrationTest : IntegrationTest() {
+
+  @Test
+  fun `count metric carries the scope's attributes`() {
+    assertThat(restTemplate.getForObject("/metric/count", String::class.java))
+      .isEqualTo("count metric increased")
+
+    val metrics = awaitMetric("countMetric")
+    assertThat(metrics.hasMetric("countMetric", "counter", 1.0)).isTrue()
+    assertThat(metrics.hasMetricWithAttribute("countMetric", "user.type", "admin")).isTrue()
+    assertThat(metrics.hasMetricWithAttribute("countMetric", "feature.version", 2)).isTrue()
+  }
+
+  @Test
+  fun `gauge metric`() {
+    assertThat(restTemplate.getForObject("/metric/gauge/14", String::class.java))
+      .isEqualTo("gauge metric tracked")
+
+    assertThat(awaitMetric("memory.free").hasMetric("memory.free", "gauge", 14.0)).isTrue()
+  }
+
+  @Test
+  fun `distribution metric`() {
+    assertThat(restTemplate.getForObject("/metric/distribution/23", String::class.java))
+      .isEqualTo("distribution metric tracked")
+
+    assertThat(
+        awaitMetric("distributionMetric").hasMetric("distributionMetric", "distribution", 23.0)
+      )
+      .isTrue()
+  }
+
+  /** Flushes first because metrics are batched before they're sent. */
+  private fun awaitMetric(name: String): SentryMetricsEvents {
+    Sentry.flush(5000)
+    return server
+      .awaitEnvelope { it.metrics()?.items?.any { metric -> metric.name == name } == true }
+      .metrics()!!
+  }
+}