From b4cabb8d92a173fb9e9d5225c1d4fb8a26cafd13 Mon Sep 17 00:00:00 2001 From: Nelson Osacky Date: Thu, 30 Jul 2026 10:39:53 +0200 Subject: [PATCH 1/2] ref(android): Remove unused lock from SentryPerformanceProvider MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The field was added in #3715 to guard onAppStartDone(), its only user. That method was removed in the 8.x.x merge (#4033), leaving the lock orphaned — it has been allocated on every cold start since, in ContentProvider.onCreate, without ever being acquired. The ISentryLifecycleToken import stays: it is still used for AppStartMetrics.staticLock in shutdown(). Co-Authored-By: Claude Opus 5 (1M context) --- .../java/io/sentry/android/core/SentryPerformanceProvider.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java b/sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java index c85fe12674d..c37d384aeec 100644 --- a/sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java +++ b/sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java @@ -23,7 +23,6 @@ import io.sentry.android.core.internal.util.SentryFrameMetricsCollector; import io.sentry.android.core.performance.AppStartMetrics; import io.sentry.android.core.performance.TimeSpan; -import io.sentry.util.AutoClosableReentrantLock; import java.io.BufferedReader; import java.io.File; import java.io.FileInputStream; @@ -46,7 +45,6 @@ public final class SentryPerformanceProvider extends EmptySecureContentProvider private final @NotNull ILogger logger; private final @NotNull BuildInfoProvider buildInfoProvider; - private final @NotNull AutoClosableReentrantLock lock = new AutoClosableReentrantLock(); @TestOnly SentryPerformanceProvider( From dd3de09aecc74c79ebdbe783ab088aa3cc1e62f1 Mon Sep 17 00:00:00 2001 From: Nelson Osacky Date: Thu, 30 Jul 2026 10:46:31 +0200 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 24d0d0740cf..1823146d55a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Performance + +- Remove an unused lock from `SentryPerformanceProvider`, which was allocated on every cold start in `ContentProvider.onCreate` without ever being acquired ([#5871](https://github.com/getsentry/sentry-java/pull/5871)) + ## 8.51.0 ### Features