Skip to content

Commit f2ee9aa

Browse files
committed
feat(bundler-plugins): Enable hidden source maps and remove them after upload in the Vite plugin
The Vite plugin decides on `build.sourcemap` in its `config` hook, because Vite warns about `rollupOptions.output.sourcemap`, and maps the decision onto each environment's output directory in `configResolved`. The post plugin that restores debug IDs for `disable-upload` builds is now always present and also stages the source maps for upload.
1 parent bc36a67 commit f2ee9aa

20 files changed

Lines changed: 400 additions & 33 deletions

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite4/basic-cjs.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles, runFileInNode }) => {
1919
"sentry-cli-mock.json": "["release","create","CURRENT_SHA","--project","fake-project"],
2020
["release","set-commits","CURRENT_SHA","--auto"],
2121
["release","finalize","CURRENT_SHA"],
22+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2223
",
2324
}
2425
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite4/basic.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles, runFileInNode }) => {
1919
"sentry-cli-mock.json": "["release","create","CURRENT_SHA","--project","fake-project"],
2020
["release","set-commits","CURRENT_SHA","--auto"],
2121
["release","finalize","CURRENT_SHA"],
22+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2223
",
2324
}
2425
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite4/release-disabled.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles }) => {
1818
",
1919
"sentry-cli-mock.json": "["release","set-commits","CURRENT_SHA","--auto"],
2020
["release","finalize","CURRENT_SHA"],
21+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2122
",
2223
}
2324
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite7/basic-cjs.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles, runFileInNode }) => {
1919
"sentry-cli-mock.json": "["release","create","CURRENT_SHA","--project","fake-project"],
2020
["release","set-commits","CURRENT_SHA","--auto"],
2121
["release","finalize","CURRENT_SHA"],
22+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2223
",
2324
}
2425
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite7/basic.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles, runFileInNode }) => {
1919
"sentry-cli-mock.json": "["release","create","CURRENT_SHA","--project","fake-project"],
2020
["release","set-commits","CURRENT_SHA","--auto"],
2121
["release","finalize","CURRENT_SHA"],
22+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2223
",
2324
}
2425
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite7/release-disabled.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles }) => {
1818
",
1919
"sentry-cli-mock.json": "["release","set-commits","CURRENT_SHA","--auto"],
2020
["release","finalize","CURRENT_SHA"],
21+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2122
",
2223
}
2324
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite8/basic-cjs.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles, runFileInNode }) => {
2020
"sentry-cli-mock.json": "["release","create","CURRENT_SHA","--project","fake-project"],
2121
["release","set-commits","CURRENT_SHA","--auto"],
2222
["release","finalize","CURRENT_SHA"],
23+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2324
",
2425
}
2526
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite8/basic.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles, runFileInNode }) => {
2020
"sentry-cli-mock.json": "["release","create","CURRENT_SHA","--project","fake-project"],
2121
["release","set-commits","CURRENT_SHA","--auto"],
2222
["release","finalize","CURRENT_SHA"],
23+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2324
",
2425
}
2526
`);

‎dev-packages/bundler-plugin-integration-tests/fixtures/vite8/release-disabled.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ test(import.meta.url, ({ runBundler, readOutputFiles }) => {
1919
",
2020
"sentry-cli-mock.json": "["release","set-commits","CURRENT_SHA","--auto"],
2121
["release","finalize","CURRENT_SHA"],
22+
["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"],
2223
",
2324
}
2425
`);

‎packages/bundler-plugins/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@
145145
"@types/node": "^20.19.0",
146146
"premove": "^4.0.0",
147147
"rolldown": "^1.0.0",
148+
"vite": "^8.3.1",
148149
"vitest": "^4.1.11",
149150
"webpack": "5.104.1"
150151
},

0 commit comments

Comments
 (0)