From 1932642b2a403eab7584cbf8159335bc63055785 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 15 Jul 2026 10:42:11 +0200 Subject: [PATCH] ref(core): Remove redundant log buffer flush Rely on Client.flush() to emit the flush hook and drain the enabled log buffer once when the client closes. Co-Authored-By: Cursor Agent Co-authored-by: Cursor --- packages/core/src/client.ts | 1 - packages/core/test/lib/client.test.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/core/src/client.ts b/packages/core/src/client.ts index 30b81de79c54..87b62479d18e 100644 --- a/packages/core/src/client.ts +++ b/packages/core/src/client.ts @@ -467,7 +467,6 @@ export abstract class Client { */ // @ts-expect-error - PromiseLike is a subset of Promise public async close(timeout?: number): PromiseLike { - _INTERNAL_flushLogsBuffer(this); const result = await this.flush(timeout); this.getOptions().enabled = false; this.emit('close'); diff --git a/packages/core/test/lib/client.test.ts b/packages/core/test/lib/client.test.ts index 227dc4b10bd4..e37c32dea309 100644 --- a/packages/core/test/lib/client.test.ts +++ b/packages/core/test/lib/client.test.ts @@ -2220,7 +2220,7 @@ describe('Client', () => { .spyOn(logsInternalModule, '_INTERNAL_flushLogsBuffer') .mockImplementation(() => undefined); - const options = getDefaultTestClientOptions({ dsn: PUBLIC_DSN }); + const options = getDefaultTestClientOptions({ dsn: PUBLIC_DSN, enableLogs: true }); const client = new TestClient(options); await client.close();