Skip to content

Commit f758b4e

Browse files
authored
Merge pull request #1419 from github/mbg/ci/no-draft
Pin action SHAs across all workflows and do not mark PR as draft in `rebuild` workflow
2 parents 71a7310 + 442011a commit f758b4e

3 files changed

Lines changed: 24 additions & 18 deletions

File tree

.github/workflows/codeql-analysis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ jobs:
2020

2121
steps:
2222
- name: Checkout repository
23-
uses: actions/checkout@v7
23+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2424

2525
# Initializes the CodeQL tools for scanning.
2626
- name: Initialize CodeQL
27-
uses: github/codeql-action/init@v4
27+
uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
2828
with:
2929
config-file: ./.github/codeql/codeql-config.yml
3030
languages: "javascript"
3131
queries: security-and-quality
3232

3333
- name: Perform CodeQL Analysis
34-
uses: github/codeql-action/analyze@v4
34+
uses: github/codeql-action/analyze@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2

.github/workflows/pr-checks.yml

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ jobs:
1111
runs-on: ubuntu-latest
1212

1313
steps:
14-
- uses: actions/checkout@v7
15-
- uses: actions/setup-node@v6
14+
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
15+
16+
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
1617
with:
1718
node-version: "24.x"
1819
cache: "npm"
@@ -25,22 +26,26 @@ jobs:
2526
runs-on: ubuntu-latest
2627

2728
steps:
28-
- uses: actions/checkout@v7
29-
- uses: actions/setup-node@v6
29+
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
30+
31+
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
3032
with:
3133
node-version: "24.x"
3234
cache: "npm"
35+
3336
- name: Install dependencies
3437
run: npm ci
38+
3539
- name: Check generated JavaScript
3640
run: .github/workflows/script/check-js.sh
3741

3842
check-json-schemas:
3943
runs-on: ubuntu-latest
4044

4145
steps:
42-
- uses: actions/checkout@v7
43-
- uses: actions/setup-node@v6
46+
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
47+
48+
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
4449
with:
4550
node-version: "24.x"
4651
cache: "npm"
@@ -53,8 +58,9 @@ jobs:
5358
runs-on: ubuntu-latest
5459

5560
steps:
56-
- uses: actions/checkout@v7
57-
- uses: actions/setup-node@v6
61+
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
62+
63+
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
5864
with:
5965
node-version: "24.x"
6066
cache: "npm"
@@ -71,18 +77,19 @@ jobs:
7177
runs-on: ${{ matrix.os }}
7278

7379
steps:
74-
- uses: actions/checkout@v7
80+
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
7581

76-
- uses: actions/setup-node@v6
82+
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
7783
with:
7884
node-version: "24.x"
7985
cache: "npm"
86+
8087
- name: Install dependencies
8188
run: npm ci
8289

8390
- name: Initialize CodeQL
8491
id: init
85-
uses: github/codeql-action/init@v4
92+
uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
8693
with:
8794
languages: javascript
8895

.github/workflows/rebuild.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525

2626
steps:
2727
- name: Checkout
28-
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
28+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2929
with:
3030
fetch-depth: 0
3131
ref: ${{ env.HEAD_REF }}
@@ -34,7 +34,7 @@ jobs:
3434
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
3535
with:
3636
node-version: 24
37-
cache: 'npm'
37+
cache: "npm"
3838

3939
- name: Remove label
4040
if: github.event_name == 'pull_request'
@@ -131,6 +131,5 @@ jobs:
131131
PR_NUMBER: ${{ github.event.pull_request.number }}
132132
run: |
133133
echo "Pushed a commit to rebuild the Action." \
134-
"Please mark the PR as ready for review to trigger PR checks." |
134+
"Please approve running the PR checks." |
135135
gh pr comment --body-file - --repo github/codeql-variant-analysis-action "$PR_NUMBER"
136-
gh pr ready --undo --repo github/codeql-variant-analysis-action "$PR_NUMBER"

0 commit comments

Comments
 (0)