C++: Add tests with missing flow sources.

Author: MathiasVP

cpp/ql/test/library-tests/dataflow/external-models/flow.ext.yml

@@ -4,6 +4,9 @@ extensions:
       extensible: sourceModel
     data: # namespace, type, subtypes, name, signature, ext, output, kind, provenance
       - ["", "", False, "ymlSource", "", "", "ReturnValue", "local", "manual"]
+      - ["", "", False, "ymlFieldSource", "", "", "ReturnValue.Field[SourceWrapper::value]", "local", "manual"]
+      - ["", "", False, "source_from_callback_template", "", "", "Argument[0].Parameter[*0].Field[SourceWrapper::value]", "local", "manual"]
+      - ["", "", False, "source_from_callback_ptr", "", "", "Argument[0].Parameter[*0].Field[SourceWrapper::value]", "local", "manual"]
   - addsTo:
       pack: codeql/cpp-all
       extensible: sinkModel

cpp/ql/test/library-tests/dataflow/external-models/sinks.expected

@@ -23,3 +23,8 @@
 | test.cpp:201:10:201:10 | x | test-sink |
 | test.cpp:218:11:218:11 | x | test-sink |
 | test.cpp:224:11:224:11 | c | test-sink |
+| test.cpp:243:13:243:17 | value | test-sink |
+| test.cpp:248:18:248:22 | value | test-sink |
+| test.cpp:254:14:254:18 | value | test-sink |
+| test.cpp:258:14:258:18 | value | test-sink |
+| test.cpp:263:15:263:19 | value | test-sink |

cpp/ql/test/library-tests/dataflow/external-models/test.cpp

@@ -223,4 +223,46 @@ void test_reverse_flow(unsigned i, unsigned j) {
 		char c = s[j];
 		ymlSink(c); // $ ir
 	}
+}
+
+
+struct SourceWrapper {
+	int value;
+};
+
+SourceWrapper ymlFieldSource();
+
+template<typename F>
+void source_from_callback_template(F);
+
+using Callback = void(*)(const SourceWrapper*);
+
+void source_from_callback_ptr(Callback);
+
+void f(const SourceWrapper* s) {
+	ymlSink(s->value); // $ MISSING: ir=250:32 ir=251:27
+}
+
+void test_source_access_path() {
+	SourceWrapper wrapper = ymlFieldSource();
+	ymlSink(wrapper.value); // $ MISSING: ir
+
+	source_from_callback_template(f);
+	source_from_callback_ptr(f);
+
+	source_from_callback_template([](const SourceWrapper* s) {
+		ymlSink(s->value); // $ MISSING: ir
+	});
+
+	source_from_callback_ptr([](const SourceWrapper* s) {
+		ymlSink(s->value); // $ MISSING: ir
+	});
+
+	struct S {
+		void operator()(const SourceWrapper* s) {
+			ymlSink(s->value); // $ MISSING: ir
+		}
+	};
+
+	source_from_callback_template(S());
 }