Skip to content

Commit e4433b1

Browse files
redsun82Copilot
andcommitted
Just: make three recipes do what they said
`misc/codegen`'s `test` declared arguments and passed none on, so anything given to it was accepted and discarded. `_ensure_long_filename` ran before the dependency that checks for an internal checkout, so outside one it built a path from an unset variable and created directories at the filesystem root, or failed on permissions while saying nothing about the real reason. The Kotlin shards pointed at a recipe name that exists nowhere. They are reached by naming their directory, which is what opting out of a downward search leaves. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 453ef9f commit e4433b1

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

‎java/ql/test-kotlin1/justfile‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import "../justfile"
22

3-
# These are CI shards of the Kotlin language tests, run as `just java
4-
# kotlin-language-tests-1`, so they only run when asked for by name.
3+
# These are CI shards of the Kotlin language tests, too long to run by accident,
4+
# so a verb coming from above passes over them and they run only when this
5+
# directory is named.
56
explicit_verbs := ['test']
67

78
# Kotlin tests may fail the diags.ql consistency test if the diagnostic limit is set.

‎java/ql/test-kotlin2/justfile‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import "../justfile"
22

3-
# These are CI shards of the Kotlin language tests, run as `just java
4-
# kotlin-language-tests-2`, so they only run when asked for by name.
3+
# These are CI shards of the Kotlin language tests, too long to run by accident,
4+
# so a verb coming from above passes over them and they run only when this
5+
# directory is named.
56
explicit_verbs := ['test']
67

78
# Kotlin tests may fail the diags.ql consistency test if the diagnostic limit is set.

‎misc/codegen/justfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import "../just/lib.just"
22

3-
test *ARGS="": (_bazel ['test', '@codeql//misc/codegen/...'])
3+
test *ARGS: (_bazel (['test', '@codeql//misc/codegen/...'] ++ ARGS))
44

55
format *ARGS=".": (_format_py ARGS)

‎python/justfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ build: (_build_dist "python")
66

77
# Long filename needed for extractor tests (too long for Git on Windows)
88
[no-cd]
9-
@_ensure_long_filename:
9+
@_ensure_long_filename: _require_semmle_code
1010
#!/usr/bin/env bash
1111
longfile="$SEMMLE_CODE/ql/python/ql/test/extractor-tests/long_path/really_rather_too_long_for_windows_path_length/with_unecessarily_longwinded_and_verbose_sub_folder/extremely_long_module_name_with_lots_of_digits_at_the_end_000000000000000000000000000000000000000000000000000000000000000000/test0000000000000000000000000000000000000000000000000000000.py"
1212
mkdir -p "$(dirname "$longfile")"

0 commit comments

Comments
 (0)