Java: Add deprecation annotations in SSA#20772
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aschackmull
force-pushed
the
java/ssa-deprecate
branch
from
2ee324e to
9ddf8b4
Compare
aschackmull
force-pushed
the
java/ssa-deprecate
branch
from
9ddf8b4 to
30d68d8
Compare
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds deprecation annotations to SSA-related predicates and classes in the Java dataflow library as a followup to PR #20761. The changes mark various SSA predicates, classes, and methods as deprecated to guide users toward newer alternatives.
Key changes:
- Deprecated several helper predicates in
SsaImpl.qllfor SSA operations - Deprecated legacy SSA classes in
SSA.qllincludingSsaVariable,SsaUpdate,SsaExplicitUpdate, andSsaImplicitInit - Deprecated member predicates and methods within those classes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll |
Added deprecation annotations to predicates ssaExplicitUpdate, ssaImplicitInit, getAUse, and ssaDefReachesEndOfBlock |
java/ql/lib/semmle/code/java/dataflow/SSA.qll |
Added deprecation annotations to classes SsaVariable, SsaUpdate, SsaExplicitUpdate, and SsaImplicitInit, as well as their member predicates getCfgNode, getAUse, and isParameterDefinition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup for #20761