Remove nanoid

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: josefs

extensions/ql-vscode/package-lock.json

@@ -2084,7 +2084,6 @@
     "js-yaml": "^5.2.3",
     "koffi": "^3.3.2",
     "msw": "^2.15.0",
-    "nanoid": "^6.0.1",
     "p-queue": "^8.0.1",
     "proper-lockfile": "^4.1.2",
     "react": "^19.3.0",

extensions/ql-vscode/package.json

@@ -38,7 +38,7 @@ import {
   getResultSetNames,
 } from "./result-set-names";
 import { isCanary } from "../config";
-import { nanoid } from "nanoid";
+import { randomUUID } from "crypto";
 
 interface ComparePair {
   from: CompletedLocalQueryInfo;
@@ -243,7 +243,7 @@ export class CompareView extends AbstractWebview<
       return;
     }
 
-    const id = nanoid();
+    const id = randomUUID();
 
     // Streaming itself is implemented like this:
     // - 1 setup message which contains the first 1,000 results

extensions/ql-vscode/src/compare/compare-view.ts

@@ -11,7 +11,7 @@ import {
 } from "fs-extra";
 import { basename, join } from "path";
 import type { Octokit } from "@octokit/rest";
-import { nanoid } from "nanoid";
+import { randomUUID } from "crypto";
 
 import type { DatabaseManager, DatabaseItem } from "./local-databases";
 import { tmpDir } from "../tmp-dir";
@@ -39,7 +39,7 @@ import { convertGithubNwoToDatabaseUrl } from "./github-databases/api";
 import { ensureZippedSourceLocation } from "./local-databases/database-contents";
 
 // The number of tries to use when generating a unique filename before
-// giving up and using a nanoid.
+// giving up and using a random UUID.
 const DUPLICATE_FILENAMES_TRIES = 10_000;
 
 export class DatabaseFetcher {
@@ -429,7 +429,7 @@ export class DatabaseFetcher {
       } else if (counter <= DUPLICATE_FILENAMES_TRIES + 5) {
         // If there are more than 10,000 similarly named databases,
         // give up on using a counter and use a random string instead.
-        folderName = `${lastName}-${nanoid()}`;
+        folderName = `${lastName}-${randomUUID()}`;
       } else {
         // This should almost never happen, but just in case, we don't want to
         // get stuck in an infinite loop.

extensions/ql-vscode/src/databases/database-fetcher.ts

@@ -5,7 +5,7 @@ import { containsPath, tmpdir } from "../common/files";
 import type { NotificationLogger } from "../common/logging";
 import { showAndLogErrorMessage } from "../common/logging";
 import { isAbsolute, normalize, resolve } from "path";
-import { nanoid } from "nanoid";
+import { randomUUID } from "crypto";
 import type { ModelConfig } from "../config";
 
 /**
@@ -245,11 +245,11 @@ export async function ensurePackLocationIsInWorkspaceFolder(
   const otherPackLocations = await Promise.all(
     Array.from({ length: 3 }).map(() =>
       packLocationToAbsolute(
-        modelConfig.getPackLocation(nanoid(), {
-          database: nanoid(),
-          language: nanoid(),
-          name: nanoid(),
-          owner: nanoid(),
+        modelConfig.getPackLocation(randomUUID(), {
+          database: randomUUID(),
+          language: randomUUID(),
+          name: randomUUID(),
+          owner: randomUUID(),
         }),
         logger,
       ),

extensions/ql-vscode/src/model-editor/extensions-workspace-folder.ts

@@ -24,7 +24,7 @@ import {
 } from "./messages";
 import type { BaseLogger, Logger } from "../common/logging";
 import { join } from "path";
-import { nanoid } from "nanoid";
+import { randomUUID } from "crypto";
 import type { QueryServerClient } from "./query-server-client";
 import { getOnDiskWorkspaceFolders } from "../common/vscode/workspace-folders";
 import { compileAndRunQueryAgainstDatabaseCore } from "./run-queries";
@@ -259,7 +259,7 @@ export class QueryRunner {
     queryBasename: string,
     templates: Record<string, string> | undefined,
   ): CoreQueryRun {
-    const id = `${queryBasename}-${nanoid()}`;
+    const id = `${queryBasename}-${randomUUID()}`;
     const outputDir = new QueryOutputDir(join(queryStorageDir, id));
 
     return {

extensions/ql-vscode/src/query-server/query-runner.ts

@@ -16,7 +16,6 @@ import {
 import type { InitialQueryInfo } from "./query-results";
 import { ensureMetadataIsComplete } from "./query-results";
 import { isQuickQueryPath } from "./local-queries/quick-query";
-import { nanoid } from "nanoid";
 import type { CodeQLCliServer } from "./codeql-cli/cli";
 import { SELECT_QUERY_NAME } from "./language-support";
 import type { DatabaseManager } from "./databases/local-databases";
@@ -28,7 +27,7 @@ import type { BaseLogger } from "./common/logging";
 import { showAndLogWarningMessage } from "./common/logging";
 import { extLogger } from "./common/logging/vscode";
 import { getErrorMessage } from "./common/helpers-pure";
-import { createHash } from "crypto";
+import { createHash, randomUUID } from "crypto";
 import { QueryOutputDir } from "./local-queries/query-output-dir";
 import { progressUpdate } from "./common/vscode/progress";
 import type { ProgressCallback } from "./common/vscode/progress";
@@ -526,7 +525,7 @@ export async function createInitialQueryInfo(
     isQuickEvalCount,
     isQuickQuery: isQuickQueryPath(selectedQuery.queryPath),
     databaseInfo,
-    id: `${basename(selectedQuery.queryPath)}-${nanoid()}`,
+    id: `${basename(selectedQuery.queryPath)}-${randomUUID()}`,
     start: new Date(),
     ...(selectedQuery.quickEval !== undefined
       ? {

extensions/ql-vscode/src/run-queries-shared.ts

@@ -1,7 +1,6 @@
 import type { Meta, StoryFn } from "@storybook/react";
 
 import { faker } from "@faker-js/faker";
-import { customAlphabet } from "nanoid";
 
 import { VariantAnalysisContainer } from "../../view/variant-analysis/VariantAnalysisContainer";
 import { VariantAnalysisAnalyzedRepos } from "../../view/variant-analysis/VariantAnalysisAnalyzedRepos";
@@ -129,16 +128,15 @@ faker.seed(42);
 
 const manyScannedRepos = Array.from({ length: 1000 }, (_, i) => {
   const mockedScannedRepo = createMockScannedRepo();
-  const nanoid = customAlphabet("123456789");
   return {
     ...mockedScannedRepo,
     analysisStatus: VariantAnalysisRepoStatus.Succeeded,
     resultCount: faker.number.int({ min: 0, max: 1000 }),
     repository: {
       ...mockedScannedRepo.repository,
       // We need to ensure the ID is unique for React keys
-      id: parseInt(nanoid()),
-      fullName: `octodemo/${nanoid()}`,
+      id: faker.number.int(),
+      fullName: `octodemo/${faker.string.numeric({ length: 21, allowLeadingZeros: false })}`,
     },
   };
 });

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisAnalyzedRepos.stories.tsx

@@ -3,7 +3,7 @@ import { window } from "vscode";
 import { join, basename, relative } from "path";
 import { dump } from "js-yaml";
 import { copy, writeFile, readFile, mkdirp, remove } from "fs-extra";
-import { nanoid } from "nanoid";
+import { randomUUID } from "crypto";
 import { tmpDir } from "../tmp-dir";
 import { getOnDiskWorkspaceFolders } from "../common/vscode/workspace-folders";
 import type { Credentials } from "../common/authentication";
@@ -167,15 +167,18 @@ async function createRemoteQueriesTempDirectory(): Promise<RemoteQueryTempDir> {
   // archive if the pack path contains any 8.3 components.
   const tmpDirPath = await expandShortPaths(tmpDir.name, extLogger);
 
-  const remoteQueryDir = join(tmpDirPath, `remote-query-${nanoid()}`);
+  const remoteQueryDir = join(tmpDirPath, `remote-query-${randomUUID()}`);
   await mkdirp(remoteQueryDir);
 
   const queryPackDir = join(remoteQueryDir, "query-pack");
   await mkdirp(queryPackDir);
 
   const compiledPackDir = join(remoteQueryDir, "compiled-pack");
 
-  const bundleFile = join(remoteQueryDir, `qlpack-${nanoid()}-generated.tgz`);
+  const bundleFile = join(
+    remoteQueryDir,
+    `qlpack-${randomUUID()}-generated.tgz`,
+  );
 
   return { remoteQueryDir, queryPackDir, compiledPackDir, bundleFile };
 }

extensions/ql-vscode/src/variant-analysis/run-remote-query.ts

@@ -20,7 +20,6 @@ const transformPackages = [
   "formdata-polyfill",
   "internmap",
   "lit",
-  "nanoid",
   "p-queue",
   "p-timeout",
   "readdirp",