From 4109865b5474b447ff104ccdddf8b18ed4064014 Mon Sep 17 00:00:00 2001 From: ohmayr Date: Thu, 6 Aug 2026 19:19:57 +0000 Subject: [PATCH] fix(generator): check for api_version header in metadata list --- .../tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 | 5 ++++- .../tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/gapic-generator/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 b/packages/gapic-generator/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 index 6c051147f937..9803ad01d68f 100644 --- a/packages/gapic-generator/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 +++ b/packages/gapic-generator/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 @@ -668,7 +668,10 @@ def test_{{ method_name }}_api_version_header(transport_name): # Establish that the api version header was sent. _, _, kw = call.mock_calls[0] - assert kw['metadata'][0] == (version_header.API_VERSION_METADATA_KEY, "{{ service.version }}") + assert ( + version_header.API_VERSION_METADATA_KEY, + "{{ service.version }}", + ) in kw['metadata'] else: pytest.skip("google-api-core>=2.19.0 is required for `google.api_core.version_header`") {% endif %}{# service.version #} diff --git a/packages/gapic-generator/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 b/packages/gapic-generator/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 index df4b71348c0b..e48c91c00783 100644 --- a/packages/gapic-generator/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 +++ b/packages/gapic-generator/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 @@ -376,7 +376,10 @@ def test_{{ method_name }}_api_version_header(transport_name): # Establish that the api version header was sent. _, _, kw = call.mock_calls[0] - assert kw['metadata'][0] == (version_header.API_VERSION_METADATA_KEY, "{{ service.version }}") + assert ( + version_header.API_VERSION_METADATA_KEY, + "{{ service.version }}", + ) in kw['metadata'] else: pytest.skip("google-api-core>=2.19.0 is required for `google.api_core.version_header`") {% endfor %}{# mode #}