From 16c4de7a922d461c377dd975c2c14a9e4556fc95 Mon Sep 17 00:00:00 2001
From: Henry Bui <henry.h.bui05@gmail.com>
Date: Sun, 12 Apr 2026 17:33:29 -0400
Subject: [PATCH 1/2] Don't enforce order in round robins

---
 src/lib/components/SpeakerList.svelte         |  9 ++++++-
 .../components/motions/page/RoundRobin.svelte | 25 +++++++++++++++++--
 .../dashboard/points-motions/+page.svelte     |  6 +----
 3 files changed, 32 insertions(+), 8 deletions(-)

diff --git a/src/lib/components/SpeakerList.svelte b/src/lib/components/SpeakerList.svelte
index 456231d..7b255ce 100644
--- a/src/lib/components/SpeakerList.svelte
+++ b/src/lib/components/SpeakerList.svelte
@@ -32,6 +32,12 @@
          * The list of all delegates recognized by this component.
          */
         delegates?: Delegate[];
+        /**
+         * Specifies what delegates can be input in the combobox.
+         * 
+         * If not specified, this falls back to `delegates`.
+         */
+        comboboxDelegates?: Delegate[];
         /**
          * The controls at the bottom of the speaker list
          * which handle the addition of new speakers.
@@ -73,6 +79,7 @@
     let {
         order = $bindable([]),
         delegates = [],
+        comboboxDelegates,
         controls = undefined,
         subcontrols = undefined,
         title = "Speakers List",
@@ -365,7 +372,7 @@
             <div class="flex flex-row gap-1 items-center">
                 <!-- Delegate combobox -->
                 <DelCombobox
-                    {delegates}
+                    delegates={comboboxDelegates ?? delegates}
                     selectionBehavior="clear"
                     class="grow"
                     forgetSelected
diff --git a/src/lib/components/motions/page/RoundRobin.svelte b/src/lib/components/motions/page/RoundRobin.svelte
index d6c8e16..ed600c2 100644
--- a/src/lib/components/motions/page/RoundRobin.svelte
+++ b/src/lib/components/motions/page/RoundRobin.svelte
@@ -5,11 +5,14 @@
     - A speakers list that is automatically populated with all delegates
 -->
 <script lang="ts">
+    import DelLabel from "$lib/components/del-label/DelLabel.svelte";
     import TimerPanel from "$lib/components/motions/TimerPanel.svelte";
     import SpeakerList from "$lib/components/SpeakerList.svelte";
     import { getSessionContext } from "$lib/context/index.svelte";
+    import { findDelegate } from "$lib/db/delegates";
     import { db } from "$lib/db/index.svelte";
     import type { Motion, Speaker } from "$lib/types";
+    import { lazyslide } from "$lib/util";
 
     interface Props {
         motion: Motion & { kind: "rr" };
@@ -22,7 +25,11 @@
     
     let timerPanel = $state<TimerPanel>();
     let speakersList = $state<SpeakerList>();
-    
+    const comboboxDelegates = $derived.by(() => {
+        let addedDelegates = new Set(order.map(s => s.key));
+        return $delegates.filter(d => !addedDelegates.has(d.id));
+    });
+
     function reset() {
         timerPanel?.reset();
     }
@@ -58,11 +65,25 @@
         <SpeakerList
             bind:order
             delegates={$delegates}
+            {comboboxDelegates}
             bind:this={speakersList}
             onBeforeSpeakerUpdate={reset}
             onMarkComplete={(key, isRepeat) => { if (!isRepeat) db.updateDelegate(key, d => { d.stats.timesSpoken++; }) }}
         >
-            {#snippet controls()}{/snippet}
+            {#snippet subcontrols()}
+                {#if !order.some(s => s.key == motion.delegate)}
+                    <div
+                        class="card card-filled p-2 flex justify-between items-center preset-filled-surface-200-800"
+                        transition:lazyslide
+                    >
+                        <DelLabel attrs={findDelegate($delegates, motion.delegate)} inline />
+                        <div>
+                            <button class="btn preset-filled-primary-500" onclick={() => speakersList?.addSpeakerFirst(motion.delegate)}>First</button>
+                            <button class="btn preset-filled-primary-500" onclick={() => speakersList?.addSpeakerLast(motion.delegate)}>Last</button>
+                        </div>
+                    </div>
+                {/if}
+            {/snippet}
         </SpeakerList>
     </div>
 </div>
\ No newline at end of file
diff --git a/src/routes/dashboard/points-motions/+page.svelte b/src/routes/dashboard/points-motions/+page.svelte
index ee2afb4..40801ea 100644
--- a/src/routes/dashboard/points-motions/+page.svelte
+++ b/src/routes/dashboard/points-motions/+page.svelte
@@ -100,11 +100,7 @@
   async function acceptMotion(motion: Motion) {
     // Update selected motion and initialize selected motion state:
     $selectedMotion = motion;
-    if (motion.kind === "rr") {
-      $selectedMotionState = { speakersList: $delegates.filter(d => d.isPresent()).map(s => createSpeaker(s.id)) };
-    } else {
-      $selectedMotionState = { speakersList: [] };
-    }
+    $selectedMotionState = { speakersList: [] };
 
     $motions = [];
     await db.updateDelegate(motion.delegate, d => { d.stats.motionsAccepted++; });

From a01a1eade6a579bb502eb37179103037dfe6ed82 Mon Sep 17 00:00:00 2001
From: Henry Bui <henry.h.bui05@gmail.com>
Date: Sun, 12 Apr 2026 17:43:21 -0400
Subject: [PATCH 2/2] Integrate first/last into SpeakerList component

---
 src/lib/components/SpeakerList.svelte         | 54 +++++++++++--------
 .../components/motions/page/ModCaucus.svelte  | 20 +------
 .../components/motions/page/RoundRobin.svelte | 23 ++------
 .../dashboard/vp-roll-call/+page.svelte       |  5 +-
 4 files changed, 40 insertions(+), 62 deletions(-)

diff --git a/src/lib/components/SpeakerList.svelte b/src/lib/components/SpeakerList.svelte
index 7b255ce..bdcbc17 100644
--- a/src/lib/components/SpeakerList.svelte
+++ b/src/lib/components/SpeakerList.svelte
@@ -10,6 +10,7 @@
     import { Dialog } from "@skeletonlabs/skeleton-svelte";
     import { tick, type Snippet } from "svelte";
     import { flip } from "svelte/animate";
+    import { slide } from "svelte/transition";
 
     import DelCombobox from "$lib/components/controls/DelCombobox.svelte";
     import DelLabel from "$lib/components/del-label/DelLabel.svelte";
@@ -38,21 +39,21 @@
          * If not specified, this falls back to `delegates`.
          */
         comboboxDelegates?: Delegate[];
+
         /**
-         * The controls at the bottom of the speaker list
-         * which handle the addition of new speakers.
-         * 
-         * If this prop is defined, this overrides the default add delegate controls
-         * provided by this component.
-         */
-        controls?: Snippet;
+         * If enabled, the controls at the bottom of the speakers list
+         * (the "add speakers", "clear speakers", and "set first/last speaker" options)
+         * are hidden.
+        */
+        hideControls?: boolean;
+
         /**
-         * Controls placed above the add speakers control.
-         * 
-         * If `controls` is defined, neither this nor the default add speakers control
-         * will appear.
-         */
-        subcontrols?: Snippet;
+         * If provided, this displays the "set first/last speaker" option,
+         * which allows you to select whether this delegate is placed first or last
+         * in the list.
+        */
+        proposer?: DelegateID;
+        
         /**
          * The title of the component, which appears at the top. 
          * 
@@ -80,8 +81,8 @@
         order = $bindable([]),
         delegates = [],
         comboboxDelegates,
-        controls = undefined,
-        subcontrols = undefined,
+        hideControls = false,
+        proposer = undefined,
         title = "Speakers List",
         extra,
         onBeforeSpeakerUpdate = undefined,
@@ -211,7 +212,7 @@
         return true;
     }
 
-    export function addSpeakerFirst(key: number): boolean {
+    function addSpeakerFirst(key: number): boolean {
         if (!delegates.some(k => k.id === key)) return false;
 
         // Successful, so add speakers:
@@ -221,7 +222,7 @@
 
         return true;
     }
-    export function addSpeakerLast(key: number): boolean {
+    function addSpeakerLast(key: number): boolean {
         if (!delegates.some(k => k.id === key)) return false;
 
         // Successful, so add speakers:
@@ -364,11 +365,22 @@
         </ol>
     </DragDropProvider>
 
-    {#if controls}
-        {@render controls()}
-    {:else}
+    {#if !hideControls}
         <div class="flex flex-col items-stretch gap-1">
-            {@render subcontrols?.()}
+            <!-- First/Last Speaker display -->
+            {#if typeof proposer !== "undefined" && !order.some(s => s.key == proposer)}
+                <div
+                    class="card card-filled p-2 flex justify-between items-center preset-filled-surface-200-800"
+                    transition:slide
+                >
+                    <DelLabel attrs={findDelegate(delegates, proposer)} inline />
+                    <div>
+                        <button class="btn preset-filled-primary-500" onclick={() => addSpeakerFirst(proposer)}>First</button>
+                        <button class="btn preset-filled-primary-500" onclick={() => addSpeakerLast(proposer)}>Last</button>
+                    </div>
+                </div>
+            {/if}
+            <!-- Add/Clear Speakers list -->
             <div class="flex flex-row gap-1 items-center">
                 <!-- Delegate combobox -->
                 <DelCombobox
diff --git a/src/lib/components/motions/page/ModCaucus.svelte b/src/lib/components/motions/page/ModCaucus.svelte
index bea3b6a..9bb2e1d 100644
--- a/src/lib/components/motions/page/ModCaucus.svelte
+++ b/src/lib/components/motions/page/ModCaucus.svelte
@@ -5,17 +5,14 @@
     - An editable speakers list
 -->
 <script lang="ts">
-    import DelLabel from "$lib/components/del-label/DelLabel.svelte";
     import { numSpeakersStr } from "$lib/components/motions/form/MotionForm.svelte";
     import TimerPanel from "$lib/components/motions/TimerPanel.svelte";
     import SpeakerList from "$lib/components/SpeakerList.svelte";
     import type Timer from "$lib/components/Timer.svelte";
     import { getSessionContext } from "$lib/context/index.svelte";
-    import { findDelegate } from "$lib/db/delegates";
     import { db } from "$lib/db/index.svelte";
     import type { Motion, Speaker } from "$lib/types";
-    import { lazyslide } from "$lib/util";
-
+    
     interface Props {
         motion: Motion & { kind: "mod" };
         order: Speaker[];
@@ -81,6 +78,7 @@
         <SpeakerList
             bind:order
             delegates={$delegates}
+            proposer={motion.delegate}
             bind:this={speakersList}
             onBeforeSpeakerUpdate={resetDel}
             onMarkComplete={(key, isRepeat) => { if (!isRepeat) db.updateDelegate(key, d => { d.stats.timesSpoken++; }) }}
@@ -88,20 +86,6 @@
             {#snippet title()}
                 Speakers List (<span class="tabular-nums">{order.length}/{numSpeakersStr(motion.totalTime, motion.speakingTime)}</span>)
             {/snippet}
-            {#snippet subcontrols()}
-                {#if !order.some(s => s.key == motion.delegate)}
-                    <div
-                        class="card card-filled p-2 flex justify-between items-center preset-filled-surface-200-800"
-                        transition:lazyslide
-                    >
-                        <DelLabel attrs={findDelegate($delegates, motion.delegate)} inline />
-                        <div>
-                            <button class="btn preset-filled-primary-500" onclick={() => speakersList?.addSpeakerFirst(motion.delegate)}>First</button>
-                            <button class="btn preset-filled-primary-500" onclick={() => speakersList?.addSpeakerLast(motion.delegate)}>Last</button>
-                        </div>
-                    </div>
-                {/if}
-            {/snippet}
         </SpeakerList>
     </div>
 </div>
\ No newline at end of file
diff --git a/src/lib/components/motions/page/RoundRobin.svelte b/src/lib/components/motions/page/RoundRobin.svelte
index ed600c2..32d7830 100644
--- a/src/lib/components/motions/page/RoundRobin.svelte
+++ b/src/lib/components/motions/page/RoundRobin.svelte
@@ -5,15 +5,12 @@
     - A speakers list that is automatically populated with all delegates
 -->
 <script lang="ts">
-    import DelLabel from "$lib/components/del-label/DelLabel.svelte";
     import TimerPanel from "$lib/components/motions/TimerPanel.svelte";
     import SpeakerList from "$lib/components/SpeakerList.svelte";
     import { getSessionContext } from "$lib/context/index.svelte";
-    import { findDelegate } from "$lib/db/delegates";
     import { db } from "$lib/db/index.svelte";
     import type { Motion, Speaker } from "$lib/types";
-    import { lazyslide } from "$lib/util";
-
+    
     interface Props {
         motion: Motion & { kind: "rr" };
         order: Speaker[]
@@ -65,25 +62,11 @@
         <SpeakerList
             bind:order
             delegates={$delegates}
+            proposer={motion.delegate}
             {comboboxDelegates}
             bind:this={speakersList}
             onBeforeSpeakerUpdate={reset}
             onMarkComplete={(key, isRepeat) => { if (!isRepeat) db.updateDelegate(key, d => { d.stats.timesSpoken++; }) }}
-        >
-            {#snippet subcontrols()}
-                {#if !order.some(s => s.key == motion.delegate)}
-                    <div
-                        class="card card-filled p-2 flex justify-between items-center preset-filled-surface-200-800"
-                        transition:lazyslide
-                    >
-                        <DelLabel attrs={findDelegate($delegates, motion.delegate)} inline />
-                        <div>
-                            <button class="btn preset-filled-primary-500" onclick={() => speakersList?.addSpeakerFirst(motion.delegate)}>First</button>
-                            <button class="btn preset-filled-primary-500" onclick={() => speakersList?.addSpeakerLast(motion.delegate)}>Last</button>
-                        </div>
-                    </div>
-                {/if}
-            {/snippet}
-        </SpeakerList>
+        />
     </div>
 </div>
\ No newline at end of file
diff --git a/src/routes/dashboard/vp-roll-call/+page.svelte b/src/routes/dashboard/vp-roll-call/+page.svelte
index 68f7ee6..e5422d0 100644
--- a/src/routes/dashboard/vp-roll-call/+page.svelte
+++ b/src/routes/dashboard/vp-roll-call/+page.svelte
@@ -245,9 +245,8 @@
                     bind:this={rightsSpeakersList}
                     onBeforeSpeakerUpdate={() => rightsTimerPanel?.reset()}
                     onMarkComplete={(key, isRepeat) => { if (!isRepeat) db.updateDelegate(key, d => { d.stats.timesSpoken++; }) }}
-                >
-                    {#snippet controls()}{/snippet}
-                </SpeakerList>
+                    hideControls
+                />
                 <!-- Timer config -->
                 <div class="flex flex-row gap-5">
                     <form class="contents" onsubmit={setDuration}>