feat(persistent-worker): critic ping-pong protocol

[hadamrd]

Parent

Part of #95 — persistent-worker epic. Depends on #108, #109.

What

On a critic verdict of REQUEST_CHANGES, transition AWAITING_CRITIC → REVISING and dispatch a follow-up worker session that resumes the SDK session_id with the critic comments as the next user message.

Acceptance

• A typed CriticReport (issue refactor(roles): migrate critic + PO from subprocess('claude -p') to the Claude Agent SDK #85 / refactor(events): typed event framework (closes #88) #99) drives the next transition:
  • APPROVE → AWAITING_CRITIC → MERGED (after auto-merge fires)
  • REQUEST_CHANGES → AWAITING_CRITIC → REVISING → AWAITING_CRITIC (loop)
  • BLOCK (sev1) → AWAITING_CRITIC → ABANDONED, label PR loop:needs-review.
• Each REVISING dispatch increments critic_iterations via store.increment_iterations.
• The critic's comments get serialised into the next worker prompt verbatim — no summarisation.

NOT in scope

• max_critic_iterations enforcement (separate ticket feat(persistent-worker): crash recovery — resume non-terminal sessions at boot #111).
• Crash recovery during ping-pong (separate ticket feat(persistent-worker): critic ping-pong protocol #110).

File pointers

• src/forge_loop/critic.py — verdict mapping
• src/forge_loop/runner/dispatch.py — ping-pong loop integration
• src/forge_loop/_critic_sdk.py — verdict comments threaded into next dispatch

Test matrix

• unit: APPROVE verdict transitions to MERGED.
• unit: REQUEST_CHANGES verdict creates a REVISING tick.
• unit: BLOCK verdict ABANDONS with the right label.
• unit: the next dispatch prompt includes the critic comments.

[hadamrd]

forge-loop: worker iteration loop exhausted after max attempts.

• last state: pushed_no_pr
• worktree: /tmp/wt-loop-110
• PR: (none)

The branch is left in place for human inspection. Run cd /tmp/wt-loop-110 && git status to pick up where the loop stopped.

[hadamrd]

forge-loop attempt — ⚠️ NO PR (~75s)

fingerprint: a419cc21c9f3

{
  "ts": "2026-05-28T12:31:48+00:00",
  "status": "no_pr",
  "pr_url": null,
  "duration_s": 75.4,
  "note": "",
  "event_count": 0,
  "brief_fingerprint": "a419cc21c9f37094409f3877bb4201503c91af48be3d01bbbda255f60f486df9"
}

[hadamrd]

forge-loop attempt — ⏳ PR OPEN (~592s)

PR: #140

fingerprint: a419cc21c9f3

{
  "ts": "2026-05-28T17:12:13+00:00",
  "status": "open",
  "pr_url": "https://github.com/hadamrd/forge-loop/pull/140",
  "duration_s": 592.1,
  "note": "",
  "event_count": 0,
  "brief_fingerprint": "a419cc21c9f37094409f3877bb4201503c91af48be3d01bbbda255f60f486df9"
}