Release version does not handle catch2 correctly.

[VictorEijkhout]

CMake Error at CMakeLists.txt:183 (add_subdirectory):
  The source directory

    /work2/00434/eijkhout/highfive/highfive-3.2.0/deps/catch2

  does not contain a CMakeLists.txt file.

I'm guessing installing from a repo clone uses a submodule?

I tried loading catch2 independently (discoverable through both pkg-config and as cmake module) but you don't seem to use that mechanism.

Am I missing a keyword or so?

[1uc]

Yes, it's a submodule and there seems to be no opt-out mechanism. (Sometimes we made it possible to pick up a system installed Catch2, but it doesn't look like HighFive is one of them.)

The pragmatic solution:

git submodule update --init --recursive

(probably don't need --recursive.)

Since it's only needed while developing HighFive, I'm not sure it's a big problem. The HighFive tests can be turned off with HIGHFIVE_UNIT_TESTS.

[1uc]

I just saw the like important word "Release version" in the title. That kinda changes things, I'll look into it a bit more deeply.

[VictorEijkhout]

Turning off the unit tests did the trick. Thanks.

Btw,

CMake Warning:
  Manually-specified variables were not used by the project:

    HIGHFIVE_PARALLEL_HDF5
    HIGHFIVE_USE_BOOST
    HIGHFIVE_USE_EIGEN
    HIGHFIVE_USE_HALF_FLOAT
    HIGHFIVE_USE_XTENSOR

Those settings come from the BBP version of highfive. Are you a full fork of that project? Were these options removed?

[1uc]

BlueBrain/HighFive was archived due to the closure of the research group BlueBrain Project. There's a successor of sorts called OpenBrain{Institute,Platform,...}. Since I felt HighFive had a rather wide user base and I absolutely hate code breaking on me, I didn't want HighFive to die. Hence, my goal is to keep it running, keep it stable, fix bugs and hopefully prevent it from fracturing into N different copies of HighFive.

The group highfive-devs is open to all former BBPers and the HighFive contributors that wanted to continue working have all been invited. Naturally, it's also open to all non-BBP, regular HighFive devs; and future devs as deemed useful. Therefore, my hope is that highfive-devs/highfive is a continuation of BlueBrain/HighFive under a GitHub org that allows us all (OBP or not) to continue working on HighFive.

Now as for all those unused variables. In v3 (which was developed at BBP), we rewrote the CMake. The core difficulty with the old CMake was that one would pick during "configure", "build" and "install" time which optional dependencies are supported by HighFive. Given that HighFive is a header-only library that didn't make sense to me. There should be nothing to configure, nothing to build and installing is copying the include dir to the appropriate locations. In v3 HighFive optional dependencies are handled very differently, if you need Eigen, you do #include<highfive/eigen.hpp> done. No fiddling CMake variables. Since your code already is able to link against Eigen, your code should already have the appropriate target_link_library(YourApp Eigen::Eigen). Which means HighFive doesn't need to worry about those things (and can't get them wrong).

There's a migration guide: https://highfive-devs.github.io/highfive/md__2home_2runner_2work_2highfive_2highfive_2doc_2migration__guide.html

it should answer any questions about transitioning from v2 to v3.