From 84886e86e1ef9bade843a0e999793571f61e8180 Mon Sep 17 00:00:00 2001 From: vtino17 Date: Tue, 21 Jul 2026 12:59:25 +0700 Subject: [PATCH 1/2] =?UTF-8?q?Fix=20Windows=20man=20pages=20guard=20(os.s?= =?UTF-8?q?ystem=20=E2=86=92=20sys.platform)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- httpie/output/ui/man_pages.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/httpie/output/ui/man_pages.py b/httpie/output/ui/man_pages.py index 0ba4974578..1b8fb58e92 100644 --- a/httpie/output/ui/man_pages.py +++ b/httpie/output/ui/man_pages.py @@ -2,6 +2,7 @@ import subprocess import os +import sys from httpie.context import Environment @@ -18,7 +19,7 @@ def is_available(program: str) -> bool: Check whether `program`'s man pages are available on this system. """ - if NO_MAN_PAGES or os.system == 'nt': + if NO_MAN_PAGES or sys.platform == 'win32': return False try: process = subprocess.run( From 3a545d26d2a92a97ec6cbdb4e5f9d5c31e35127e Mon Sep 17 00:00:00 2001 From: Valentino Saputra Date: Tue, 11 Aug 2026 06:18:56 +0700 Subject: [PATCH 2/2] test: cover Windows man-page guard --- httpie/output/ui/man_pages.py | 2 +- tests/test_man_pages.py | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 tests/test_man_pages.py diff --git a/httpie/output/ui/man_pages.py b/httpie/output/ui/man_pages.py index 1b8fb58e92..c0fdf465ff 100644 --- a/httpie/output/ui/man_pages.py +++ b/httpie/output/ui/man_pages.py @@ -1,7 +1,7 @@ """Logic for checking and displaying man pages.""" -import subprocess import os +import subprocess import sys from httpie.context import Environment diff --git a/tests/test_man_pages.py b/tests/test_man_pages.py new file mode 100644 index 0000000000..9b4c25625b --- /dev/null +++ b/tests/test_man_pages.py @@ -0,0 +1,12 @@ +from unittest.mock import Mock + +from httpie.output.ui import man_pages + + +def test_man_pages_are_unavailable_on_windows(monkeypatch): + run = Mock() + monkeypatch.setattr(man_pages.sys, 'platform', 'win32') + monkeypatch.setattr(man_pages.subprocess, 'run', run) + + assert man_pages.is_available('http') is False + run.assert_not_called()