Skip to content

Commit b391871

Browse files
committed
chore: point .nvmrc at 22, the version CI actually runs
.nvmrc said 20 while all six node-version declarations across the five workflows said 22. That is the one inconsistency .nvmrc exists to prevent: its whole job is making a local shell match CI, so `nvm use` was arranging for contributors to reproduce bugs on a version nothing tests, and to miss ones that only appear on 22. CI is the authority here, not the other way round — 22 is what every workflow has been running green on, so .nvmrc moves to meet it rather than dragging six workflows down to 20. The comment in checks.yml that recorded the mismatch ("Note .nvmrc says 20 — worth reconciling, but not silently from here") is replaced rather than deleted: it now says all six are 22 and to change them together, which is the part that was actually worth writing down. It also said "the other two workflows" from back when there were three. Not touched: moving everything to 24. That is a real decision with a runtime behind it, not a bookkeeping fix, and it does not belong in the same commit.
1 parent dadc6d0 commit b391871

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/checks.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,10 @@ jobs:
4444

4545
- uses: actions/setup-node@v7
4646
with:
47-
# Matches the other two workflows. Note .nvmrc says 20 — worth
48-
# reconciling, but not silently from here.
47+
# 22 in all five workflows and in .nvmrc, which is the point: .nvmrc
48+
# exists so a local shell runs what CI runs, and it said 20 while every
49+
# workflow said 22 — so `nvm use` was arranging to reproduce bugs on a
50+
# version nothing tested. Change all six together or not at all.
4951
node-version: 22
5052
cache: npm
5153

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
22

0 commit comments

Comments
 (0)