Completion of error handling

[elfring]

Would you like to add more error handling for return values from functions like the following?

• sigaction ⇒ reg_sigterm_handler
• strdup ⇒ get_args_count

[pperycz]

Hello!

Thank you for your feedback! We will review your suggestions and come back with an answer as soon as possible.

Best regards,
Przemyslaw Perycz

[sdpslfz]

Hi Elfring:

Thanks for your suggestion, and we are fixing this issue on code reviewing. And we would have this done in the next release.

Best regards,
Benima

[elfring]

I suggest to avoid ignorance of return values a bit more.

Are you interested to apply aspect-oriented software development?
How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

[sdpslfz]

Hi elfring:

We are required to eliminate ignorance of return values in the code reviewing for the next stage, and thanks again for your suggestion.
Also I think certain error detection and corresponding exception handling could be encapsulated as a reusable aspect. And we would take a discussion on this suggestion.

Best regards,
Benima

[elfring]

How do you think about to improve static source code analysis also for your software?

Do you find information sources like the following useful?

• Article "A Reusable Aspect for Memory Allocation Checking"
• Document "Aspect-Oriented Software Development - An Introduction" by Johan Brichau and Theo D'Hondt
• Paper "On Typesafe Aspect Implementations in C++" by Daniel Lohmann and Olaf Spinczyk

[sdpslfz]

Hi elfring:

Thanks for your suggestions. We are now focus on other issues, so we had a late response.
We are now using klocwork for static source code analysis.
BTW, please raise another issue if you have further suggestions.

Best regards,
Benima

[elfring]

I am curious if source code will be improved around a check like "NPD.FUNC.MIGHT" (and more?).

[sdpslfz]

Hi Elfring:

We think that checkings like "NPD.FUNC.MIGHT" would find out the potential issues in the code, even though sometimes it would not be perfect as always.
And the result lies on how we fix the issue, not the tools for checking.

Thanks
Benima