The noise floor is per-page: pinned tolerances are load-bearing on CI - #570
Merged
Conversation
Two update-baselines dispatches of the same commit, twelve hours apart, left 135 of 147 Linux baselines byte-identical - CI is deterministic for ~92% of pages. Eleven font/SVG-heavy pages moved 0.0003-0.002, and every one of them pins tolerance 0.03 at its call site. Those pins absorb a rasteriser; they are not padding left over from the blind era, and lowering them toward the 0.0001 default would redden CI permanently on pages with no defect. The ~1e-6 noise figure this repo has been quoting is macOS-local and was being read as universal. Corrected in both places it appears, with the rule that a page's floor is its measured noise on the platform that judges it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011SP5gaqXEgUie8pdFrmbeJ
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two update-baselines dispatches of the same commit, twelve hours apart, left
135 of 147 Linux baselines byte-identical - CI is deterministic for ~92% of
pages. Eleven font/SVG-heavy pages moved 0.0003-0.002, and every one of them
pins tolerance 0.03 at its call site. Those pins absorb a rasteriser; they are
not padding left over from the blind era, and lowering them toward the 0.0001
default would redden CI permanently on pages with no defect.
The ~1e-6 noise figure this repo has been quoting is macOS-local and was
being read as universal. Corrected in both places it appears, with the rule
that a page's floor is its measured noise on the platform that judges it.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_011SP5gaqXEgUie8pdFrmbeJ