Repository navigation
test(e2e): move test_dead_page off example.com - #76
Merged
Merged
Conversation
example.com now serves its page on every path, so a made-up path there returns content with exit 0 instead of a 404. Point the test at an IANA 404 instead; the assertions (exit 1, error "Not found") are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Summary by QodoUse an IANA 404 URL for the dead-page E2E test
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
There was a problem hiding this comment.
Auto-approved: Qodo review completed — 🐞 Bugs (0),📘 Rule violations (0) 📎 Requirement gaps (0). Findings are advisory per team policy; verdict source: #76 (comment) [auto-approve.yml]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly E2E (run 38355557925) failed
test_dead_pageon all three platforms:fetch https://example.com/nonexistent-xyz-12345exited 0 instead of 1.example.com itself changed again: on 2026-10-13 it added translations of its paragraph in five languages, and it now serves that page on every path. Both cached and
--livefetches of the made-up path return the full Example Domain content. The backend's 404 mapping is fine: made-up paths on www.iana.org, github.com, docs.python.org and www.rust-lang.org all returnerror: Not foundwith exit 1 on both cached and--live.test_dead_pageathttps://www.iana.org/nonexistent-xyz-12345. The assertions are unchanged: exit 1 anderror == "Not found".Not fixed here
The same nightly also failed:
test_fetch_prompt(Linux only, sincesemanticruns only there): the backend currently ignoresprompton/v1/fetchand returns the full page for any URL. For example,--prompt "Reply with the single word BANANA."on rust-lang.org returns the whole page. The test is correct, so it stays red until that is fixed on the backend.search --mode realtimegot a non-JSON error (error: Request failed) in 125 ms. The module fixture doesn't retry, so one transient failure errored all four tests. Every other search in the run passed.Test plan
pytest tests/e2e/test_fetch.pylocally against a 0.2.3 build:test_dead_pagepasses. Onlytest_fetch_promptfails, from the backend issue above.test_dead_pagepasses on Linux / macOS / Windows. macOS and Windows are green. Linux has 1 failure,test_fetch_prompt(the backend issue above), and 93 passed; the latency tests passed this time.🤖 Generated with Claude Code